Bugzilla – Attachment 184421 Details for
Bug 35237
Duplicate ids in markup of patron card layout edit form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35237: Give patron card layout form elements unique IDs
Bug-35237-Give-patron-card-layout-form-elements-un.patch (text/plain), 5.91 KB, created by
Aleisha Amohia
on 2025-07-20 22:09:10 UTC
(
hide
)
Description:
Bug 35237: Give patron card layout form elements unique IDs
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2025-07-20 22:09:10 UTC
Size:
5.91 KB
patch
obsolete
>From 8bfa8dbe29de9afad7e467b27057a9dd30efe823 Mon Sep 17 00:00:00 2001 >From: Courtney Brown <courtneybrown@catalyst.net.nz> >Date: Thu, 17 Jul 2025 23:09:15 +0000 >Subject: [PATCH] Bug 35237: Give patron card layout form elements unique IDs > >This patch ensures the following patron card layout form fields use unique IDs: >- page side >- guide box >- guide grid > >This semantically links the options to their labels so is more accessible for screen readers and keyboard navigation. > >The patch also adds a 'default' option to the original labels so they can become useful elements on the form rather than just text labels. > >Test plan: >1. Head to 'tools' then 'patron card creator' >2. Click on 'Layouts' underneath 'Manage' >3. Click on 'Edit' >4. Confirm it's easy to tell which options are available and chosen for page side, guide box, and guide grid >5. Click on the text labels for the options i.e. front, back, on, off. Confirm the relevant radio button is selected > >Sponsored-by: Catalyst IT >--- > .../en/modules/patroncards/edit-layout.tt | 24 ++++++++++++------- > 1 file changed, 15 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >index c4c9c658147..e227d8fe8ef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >@@ -80,27 +80,33 @@ > </select> > </li> > <li> >- <label for="page_side">Page side: </label> >+ <label for="page_side_front">Page side: </label> > [% IF ( page_side ) %] >- <input type="radio" name="page_side" id="page_side" value="F" />Front <input type="radio" name="page_side" id="page_side" value="B" checked="checked" />Back >+ <label for="page_side_front">Front: <input type="radio" name="page_side" id="page_side_front" value="F" /></label> >+ <label for="page_side_back">Back: <input type="radio" name="page_side" id="page_side_back" value="B" checked="checked" /></label> > [% ELSE %] >- <input type="radio" name="page_side" id="page_side" value="F" checked="checked" />Front <input type="radio" name="page_side" id="page_side" value="B" />Back >+ <label for="page_side_front">Front: <input type="radio" name="page_side" id="page_side_front" value="F" checked="checked" /></label> >+ <label for="page_side_back">Back: <input type="radio" name="page_side" id="page_side_back" /></label> > [% END %] > </li> > <li> >- <label for="guide_box">Guide box:</label> >+ <label for="guide_box_on">Guide box:</label> > [% IF ( guide_box ) %] >- <input type="radio" name="guide_box" id="guide_box" value="1" checked="checked" />On <input type="radio" name="guide_box" id="guide_box" value="0" />Off >+ <label for="guide_box_on">On: <input type="radio" name="guide_box" id="guide_box_on" value="0" /></label> >+ <label for="guide_box_off">Off: <input type="radio" name="guide_box" id="guide_box_off" value="1" checked="checked" /></label> > [% ELSE %] >- <input type="radio" name="guide_box" id="guide_box" value="1" />On <input type="radio" name="guide_box" id="guide_box" value="0" checked="checked" />Off >+ <label for="guide_box_on">On: <input type="radio" name="guide_box" id="guide_box_on" value="0" checked="checked" /></label> >+ <label for="guide_box_off">Off: <input type="radio" name="guide_box" id="guide_box_off" value="1" /></label> > [% END %] > </li> > <li> >- <label for="guide_grid">Guide grid:</label> >+ <label for="guide_grid_off">Guide grid:</label> > [% IF ( guide_grid ) %] >- <input type="radio" name="guide_grid" id="guide_grid" value="1" checked="checked" />On <input type="radio" name="guide_grid" id="guide_grid" value="0" />Off >+ <label for="guide_grid_on">On: <input type="radio" name="guide_grid" id="guide_grid_on" value="1" checked="checked" /></label> >+ <label for="guide_grid_off">Off: <input type="radio" name="guide_grid" id="guide_grid_off" value="0" /></label> > [% ELSE %] >- <input type="radio" name="guide_grid" id="guide_grid" value="1" />On <input type="radio" name="guide_grid" id="guide_grid" value="0" checked="checked" />Off >+ <label for="guide_grid_on">On: <input type="radio" name="guide_grid" id="guide_grid_on" value="1" /></label> >+ <label for="guide_grid_off">Off: <input type="radio" name="guide_grid" id="guide_grid_off" value="0" checked="checked" /></label> > [% END %] > </li> > </ol> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35237
:
184253
| 184421