Bugzilla – Attachment 184425 Details for
Bug 40337
checkprevcheckout must be defined as ENUM at DB level
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40337: Remove test of datatype
Bug-40337-Remove-test-of-datatype.patch (text/plain), 4.09 KB, created by
Jonathan Druart
on 2025-07-21 08:19:37 UTC
(
hide
)
Description:
Bug 40337: Remove test of datatype
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-21 08:19:37 UTC
Size:
4.09 KB
patch
obsolete
>From c4e420534c4aa7db8de040e2c226f4270e7c9e95 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 21 Jul 2025 10:16:52 +0200 >Subject: [PATCH] Bug 40337: Remove test of datatype > >Keep the UPDATE to adjust bad data however. >--- > installer/data/mysql/db_revs/250600003.pl | 66 ++++++----------------- > 1 file changed, 15 insertions(+), 51 deletions(-) > >diff --git a/installer/data/mysql/db_revs/250600003.pl b/installer/data/mysql/db_revs/250600003.pl >index da2e544841c..e87c5cba156 100755 >--- a/installer/data/mysql/db_revs/250600003.pl >+++ b/installer/data/mysql/db_revs/250600003.pl >@@ -8,82 +8,46 @@ return { > my ($args) = @_; > my ( $dbh, $out ) = @$args{qw(dbh out)}; > >- my $col_type_borrowers = $dbh->selectrow_array( >+ $dbh->do( > q{ >- SELECT COLUMN_TYPE >- FROM INFORMATION_SCHEMA.COLUMNS >- WHERE TABLE_SCHEMA = DATABASE() >- AND TABLE_NAME = 'borrowers' >- AND COLUMN_NAME = 'checkprevcheckout' >- } >- ); >- >- if ( $col_type_borrowers !~ /^enum/i ) { >- $dbh->do( >- q{ > UPDATE borrowers > SET checkprevcheckout = 'inherit' > WHERE checkprevcheckout NOT IN ('yes','no','inherit'); > } >- ); >- $dbh->do( >- q{ >+ ); >+ $dbh->do( >+ q{ > ALTER TABLE borrowers > MODIFY COLUMN `checkprevcheckout` enum('yes', 'no', 'inherit') NOT NULL DEFAULT 'inherit' COMMENT 'produce a warning for this patron if this item has previously been checked out to this patron if ''yes'', not if ''no'', defer to category setting if ''inherit''.' > } >- ); >- } >- >- my $col_type_categories = $dbh->selectrow_array( >- q{ >- SELECT COLUMN_TYPE >- FROM INFORMATION_SCHEMA.COLUMNS >- WHERE TABLE_SCHEMA = DATABASE() >- AND TABLE_NAME = 'categories' >- AND COLUMN_NAME = 'checkprevcheckout' >- } > ); > >- if ( $col_type_categories !~ /^enum/i ) { >- $dbh->do( >- q{ >+ $dbh->do( >+ q{ > UPDATE categories > SET checkprevcheckout = 'inherit' > WHERE checkprevcheckout NOT IN ('yes','no','inherit'); > } >- ); >- $dbh->do( >- q{ >+ ); >+ $dbh->do( >+ q{ > ALTER TABLE categories > MODIFY COLUMN `checkprevcheckout` enum('yes', 'no', 'inherit') NOT NULL DEFAULT 'inherit' COMMENT 'produce a warning for this patron category if this item has previously been checked out to this patron if ''yes'', not if ''no'', defer to syspref setting if ''inherit''.' > } >- ); >- } >- >- my $col_type_deletedborrowers = $dbh->selectrow_array( >- q{ >- SELECT COLUMN_TYPE >- FROM INFORMATION_SCHEMA.COLUMNS >- WHERE TABLE_SCHEMA = DATABASE() >- AND TABLE_NAME = 'deletedborrowers' >- AND COLUMN_NAME = 'checkprevcheckout' >- } > ); > >- if ( $col_type_deletedborrowers !~ /^enum/i ) { >- $dbh->do( >- q{ >+ $dbh->do( >+ q{ > UPDATE deletedborrowers > SET checkprevcheckout = 'inherit' > WHERE checkprevcheckout NOT IN ('yes','no','inherit'); > } >- ); >- $dbh->do( >- q{ >+ ); >+ $dbh->do( >+ q{ > ALTER TABLE deletedborrowers > MODIFY COLUMN `checkprevcheckout` enum('yes', 'no', 'inherit') NOT NULL DEFAULT 'inherit' COMMENT 'produce a warning for this patron if this item has previously been checked out to this patron if ''yes'', not if ''no'', defer to category setting if ''inherit''.' > } >- ); >- } >+ ); > }, > }; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40337
:
183918
|
183919
|
183946
|
183947
|
183948
|
183969
|
183970
|
184396
|
184397
| 184425 |
184856