Bugzilla – Attachment 184466 Details for
Bug 39877
CI - Incremental runs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39877: Fix confusion with URL prefix
Bug-39877-Fix-confusion-with-URL-prefix.patch (text/plain), 2.49 KB, created by
Jonathan Druart
on 2025-07-22 07:52:53 UTC
(
hide
)
Description:
Bug 39877: Fix confusion with URL prefix
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-22 07:52:53 UTC
Size:
2.49 KB
patch
obsolete
>From 80eac2e8e6253e480ad88fc93e84854f8d45ad7f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 22 Jul 2025 09:45:06 +0200 >Subject: [PATCH] Bug 39877: Fix confusion with URL prefix > >git clone needs https://, but we need to remove it to build the push url >--- > Koha/Devel/CI/IncrementalRuns.pm | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > >diff --git a/Koha/Devel/CI/IncrementalRuns.pm b/Koha/Devel/CI/IncrementalRuns.pm >index ec183b8632b..81425c1c5a3 100644 >--- a/Koha/Devel/CI/IncrementalRuns.pm >+++ b/Koha/Devel/CI/IncrementalRuns.pm >@@ -51,7 +51,7 @@ Koha::Devel::CI::IncrementalRuns is a module designed to manage incremental CI r > my $ci = Koha::Devel::CI::IncrementalRuns->new({ > incremental_run => 1, > git_repo_dir => '/path/to/repo', >- repo_url => 'gitlab.com/koha-community/koha-ci-results.git', >+ repo_url => 'https://gitlab.com/koha-community/koha-ci-results.git', > report => 1, > token => 'your_token', > test_name => 'test_name', >@@ -76,13 +76,12 @@ sub new { > incremental_run => $ENV{KOHA_CI_INCREMENTAL_RUNS} // 0, > git_repo_dir => $args->{git_repo_dir} // q{/tmp/koha-ci-results}, > repo_url => $args->{repo_url} // $ENV{KOHA_CI_INCREMENTAL_RUN_REPO_URL} >- // q{gitlab.com/koha-community/koha-ci-results.git}, >+ // q{https://gitlab.com/koha-community/koha-ci-results.git}, > report => $args->{report} // $ENV{KOHA_CI_INCREMENTAL_RUNS_REPORT}, > token => $args->{token} // $ENV{KOHA_CI_INCREMENTAL_RUNS_TOKEN}, > test_name => $args->{test_name}, > context => $args->{context}, > }; >- bless $self, $class; > > unless ( $self->{test_name} ) { > my @caller_info = caller(); >@@ -100,6 +99,8 @@ sub new { > > make_path("$self->{git_repo_dir}/$self->{test_name}"); > } >+ >+ bless $self, $class; > return $self; > } > >@@ -173,7 +174,9 @@ sub report_results { > > qx{git -C $self->{git_repo_dir} add $failure_file}; > qx{git -C $self->{git_repo_dir} commit -m "$commit_id - $self->{test_name}"}; >- qx{git -C $self->{git_repo_dir} push https://gitlab-ci-token:$self->{token}\@$self->{repo_url} main}; >+ ( my $push_domain = $self->{repo_url} ) =~ s{^https://}{}; >+ my $push_url = "https://gitlab-ci-token:$self->{token}\@$push_domain"; >+ qx{git -C $self->{git_repo_dir} push $push_url main}; > } > > 1; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39877
:
182308
|
182309
|
182310
|
182311
|
182347
|
182348
|
182349
|
182350
|
182355
|
182356
|
182357
|
182358
|
183795
|
183796
|
183797
|
183798
|
184462
|
184463
|
184464
|
184465
|
184466
|
184779
|
184780
|
184781
|
184782
|
184783
|
184785
|
184875
|
184876
|
184877
|
184878
|
184879
|
184880