Bugzilla – Attachment 184475 Details for
Bug 40395
Allow selecting multiple holds in patron detail page to perform actions on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40395: Reimplement delete
Bug-40395-Reimplement-delete.patch (text/plain), 4.57 KB, created by
Pedro Amorim
on 2025-07-22 13:10:26 UTC
(
hide
)
Description:
Bug 40395: Reimplement delete
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-07-22 13:10:26 UTC
Size:
4.57 KB
patch
obsolete
>From f551838d03bd5feb87ca0381a2504b99cefdebb6 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 15 Jul 2025 12:47:51 +0000 >Subject: [PATCH] Bug 40395: Reimplement delete > >--- > .../prog/en/includes/patron-detail-tabs.inc | 17 ++++----------- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 21 +++++-------------- > 2 files changed, 9 insertions(+), 29 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >index 8389312a123..ef6865313fa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >@@ -1,6 +1,7 @@ > <!-- patron-detail-tabs.inc --> > [% USE raw %] > [% PROCESS 'html_helpers.inc' %] >+[% PROCESS 'modals/holds_table_modals.inc' %] > [% WRAPPER tabs id= "finesholdsissues" %] > [% WRAPPER tabs_nav %] > [% WRAPPER tab_item tabname= "checkouts" bt_active= 1 %] >@@ -165,22 +166,12 @@ > </table> > > <fieldset class="action"> >- <input type="submit" class="btn btn-primary cancel" name="submit" value="Cancel marked holds" /> >- >- [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %] >- [% IF hold_cancellation.count %] >- <label for="cancellation-reason">Cancellation reason:</label> >- <input type="hidden" name="op" value="cud-cancelall" /> >- <select name="cancellation-reason" id="cancellation-reason"> >- <option value="">No reason given</option> >- [% FOREACH reason IN hold_cancellation %] >- <option value="[% reason.authorised_value | html %]">[% reason.lib | html %]</option> >- [% END %] >- </select> >- [% END %] >+ <button class="btn btn-primary cancel_selected_holds" data-bulk="true"></button> > </fieldset> > </form> > >+ [% PROCESS 'cancel-hold-modal' form_action = '/cgi-bin/koha/reserve/modrequest.pl' from_param = patronpage %] >+ > [% IF Koha.Preference('SuspendHoldsIntranet') %] > <fieldset class="action"> > <button class="btn btn-primary suspend_selected_holds" data-bulk="true"></button> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index aa69b284779..466597d4b85 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -353,26 +353,15 @@ $(document).ready(function () { > }, > }, > { >- orderable: false, > data: function (oObj) { > return ( >- "<select name='rank-request'>" + >- "<option value='n'>" + >- __("No") + >- "</option>" + >- "<option value='del'>" + >- __("Yes") + >- "</option>" + >- "</select>" + >- "<input type='hidden' name='biblionumber' value='" + >- oObj.biblionumber + >- "'>" + >- "<input type='hidden' name='borrowernumber' value='" + >+ '<a class="cancel-hold deny" title="Cancel hold" data-borrowernumber="' + > borrowernumber + >- "'>" + >- "<input type='hidden' name='reserve_id' value='" + >+ '" data-biblionumber="' + >+ oObj.biblionumber + >+ '" data-id="' + > oObj.reserve_id + >- "'>" >+ '" href="#"> <i class="fa fa-trash" aria-label="Cancel hold"></i></a>' > ); > }, > }, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40395
:
184109
|
184110
|
184111
|
184112
|
184113
|
184114
|
184115
|
184116
|
184134
|
184135
|
184136
|
184137
|
184138
|
184139
|
184140
|
184141
|
184398
|
184399
|
184400
|
184401
|
184402
|
184403
|
184404
|
184405
|
184434
|
184435
|
184437
|
184470
|
184471
|
184472
|
184473
|
184474
| 184475 |
184476
|
184477
|
184478
|
184479