Bugzilla – Attachment 184477 Details for
Bug 40395
Allow selecting multiple holds in patron detail page to perform actions on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40395: Add checkboxes column to holds table
Bug-40395-Add-checkboxes-column-to-holds-table.patch (text/plain), 4.03 KB, created by
Pedro Amorim
on 2025-07-22 13:10:32 UTC
(
hide
)
Description:
Bug 40395: Add checkboxes column to holds table
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-07-22 13:10:32 UTC
Size:
4.03 KB
patch
obsolete
>From 76d5f7e862e0a40911b08842be0b8a4b2d198638 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 15 Jul 2025 12:47:29 +0000 >Subject: [PATCH] Bug 40395: Add checkboxes column to holds table > >Test plan, k-t-d, patches applied: >1) Search for 'music': >http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=music >2) Click the 'Select all' link on the left of the search toolbar >3) Click the 'Place hold' button on the same toolbar >4) On the patron input, add 'koha' >5) You need to pick the 'Pickup location' specifically for each hold. Click 'Place holds' >6) On this screen (reserve/request.pl) ensure the table(s) work. Selecting all works. Canceling selected works (it doesn't refresh immediatelly, it's a background job). Suspend works as before, sorting, etc. >7) Now visit the patron details page: >http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 >8) Click the 'Holds' tab. >9) Verify we now have a checkbox column at the start. >10) Test that selecting multiple holds and canceling selected works. Same for suspending. >11) Test the canceling or suspending a specific hold works. >12) Test that this table is compatible with AutoResumeSuspendedHolds sys pref i.e. you're unable to set a resume date when suspending in bulk or single if this sys pref is turned off. >13) Repeat steps 8-12 but for the circulation page from patron details at: >http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 >14) Ensure tests added for API REST endpoint added here pass: >prove t/db_dependent/api/v1/holds.t >--- > .../prog/en/includes/patron-detail-tabs.inc | 3 ++- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 14 ++++++++++++++ > 2 files changed, 16 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >index 0322d532061..b59888eca45 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >@@ -146,9 +146,10 @@ > <form action="/cgi-bin/koha/reserve/modrequest.pl" method="post"> > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="from" value="circ" /> >- <table id="holds-table" style="width: 100% !Important;"> >+ <table id="holds-table" class="holds_table" style="width: 100% !Important;"> > <thead> > <tr> >+ <th id="checkbox" data-colname="checkbox"><input type="checkbox" class="select_hold_all" /></th> > <th>Hold date</th> > <th class="anti-the">Title</th> > <th>Call number</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 5f12ebea2ee..f9c6c8d55e9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -158,6 +158,20 @@ $(document).ready(function () { > autoWidth: false, > dom: '<"table_controls"B>rt', > columns: [ >+ { >+ orderable: false, >+ data: function (oObj) { >+ return ( >+ '<input type="checkbox" class="select_hold" data-id="' + >+ oObj.reserve_id + >+ '" data-borrowernumber="' + >+ borrowernumber + >+ '" data-biblionumber="' + >+ oObj.biblionumber + >+ '">' >+ ); >+ }, >+ }, > { > data: { > _: "reservedate_formatted", >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40395
:
184109
|
184110
|
184111
|
184112
|
184113
|
184114
|
184115
|
184116
|
184134
|
184135
|
184136
|
184137
|
184138
|
184139
|
184140
|
184141
|
184398
|
184399
|
184400
|
184401
|
184402
|
184403
|
184404
|
184405
|
184434
|
184435
|
184437
|
184470
|
184471
|
184472
|
184473
|
184474
|
184475
|
184476
| 184477 |
184478
|
184479