Bugzilla – Attachment 184486 Details for
Bug 40466
Zebra status misleading in "Server information" tab.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40466: Zebra status misleading in "Server information" tab
Bug-40466-Zebra-status-misleading-in-Server-inform.patch (text/plain), 2.58 KB, created by
David Flater
on 2025-07-22 16:08:26 UTC
(
hide
)
Description:
Bug 40466: Zebra status misleading in "Server information" tab
Filename:
MIME Type:
Creator:
David Flater
Created:
2025-07-22 16:08:26 UTC
Size:
2.58 KB
patch
obsolete
>From f0b391dde3878935bc31b2d02ea378bfc85ab228 Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Tue, 22 Jul 2025 10:54:02 +0000 >Subject: [PATCH] Bug 40466: Zebra status misleading in "Server information" > tab > >After changes to about.pl the checking of the Zebra status has landed >in "sysinfo" section instead of "about". As a result "Zebra status" >always reports "Running" even if Zebra is off. > >Test plan: >========== >1. Turn zebra server off (koha-zebra --stop kohadev) and check in > "Server information" (More > About Koha) the "Zebra status" info. > You will see "Running". >2. Apply the patch ; restart_all ; koha-zebra --stop kohadev >3. Check "Zebra status" in "Server information". You should see now: > "Zebra server seems not to be available. Is it started?". > >Signed-off-by: David Flater <flaterdavid@gmail.com> >--- > about.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/about.pl b/about.pl >index 93532d1b0f..7f8f113425 100755 >--- a/about.pl >+++ b/about.pl >@@ -132,6 +132,8 @@ if ( $tab eq 'about' ) { > > my $zebraVersion = `zebraidx -V`; > >+ my $errZebraConnection = C4::Context->Zconn( "biblioserver", 0 )->errcode(); >+ > # Check running PSGI env > if ( C4::Context->psgi_env ) { > $template->param( >@@ -173,6 +175,7 @@ if ( $tab eq 'about' ) { > where_is_memcached_config => $where_is_memcached_config, > perlPath => $perl_path, > zebraVersion => $zebraVersion, >+ errZebraConnection => $errZebraConnection, > kohaVersion => $versions{'kohaVersion'}, > osVersion => $versions{'osVersion'}, > perlVersion => $versions{'perlVersion'}, >@@ -230,8 +233,6 @@ if ( $tab eq 'sysinfo' ) { > ); > $template->param( invalid_yesno => $invalid_yesno ); > >- my $errZebraConnection = C4::Context->Zconn( "biblioserver", 0 )->errcode(); >- > my $warnIsRootUser = ( !$loggedinuser ); > > my $warnNoActiveCurrency = ( !defined Koha::Acquisition::Currencies->get_active ); >@@ -599,7 +600,6 @@ if ( $tab eq 'sysinfo' ) { > $warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist, > warnPrefKohaAdminEmailAddress => $warnPrefKohaAdminEmailAddress, > warnPrefOpacHiddenItems => $warnPrefOpacHiddenItems, >- errZebraConnection => $errZebraConnection, > warnIsRootUser => $warnIsRootUser, > warnNoActiveCurrency => $warnNoActiveCurrency, > warnNoTemplateCaching => ( C4::Context->config('template_cache_dir') ? 0 : 1 ), >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40466
:
184467
|
184486
|
184524