Bugzilla – Attachment 184628 Details for
Bug 40516
Boolean filters are broken on datatables
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40516: Restore falsy boolean filter values
Bug-40516-Restore-falsy-boolean-filter-values.patch (text/plain), 1.34 KB, created by
Matt Blenkinsop
on 2025-07-25 13:39:46 UTC
(
hide
)
Description:
Bug 40516: Restore falsy boolean filter values
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2025-07-25 13:39:46 UTC
Size:
1.34 KB
patch
obsolete
>From db75e898f1ad08611ab2a1e3842b1bb76ce3747a Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> >Date: Fri, 25 Jul 2025 14:36:18 +0100 >Subject: [PATCH] Bug 40516: Restore falsy boolean filter values > >Test plan: >1) Navigate to ERM agreements and create an agreement >2) In the agreements table, click on the filter for Is Perpetual >3) Only the option for 'Yes' will be shown >4) Apply patch >5) yarn js:build >6) Hard refresh the browser and repeat step 2 >7) Filter options for Yes and No should be available >8) Check the filtering works appropriately >--- > koha-tmpl/intranet-tmpl/prog/js/datatables.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >index bdfe317ddaa..28d1cf5eee8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >@@ -1059,7 +1059,7 @@ function _dt_add_filters(table_node, table_dt, filters_options = {}) { > } > $(filters_options[i]) > .filter(function () { >- return this._id && this._str; >+ return this._id !== "" && this._str !== ""; > }) > .each(function () { > let optionValue = >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40516
:
184628
|
184636
|
184677