Bugzilla – Attachment 184656 Details for
Bug 40114
Can't select new library when editing a desk
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40114: Can't select new library when editing a desk
Bug-40114-Cant-select-new-library-when-editing-a-d.patch (text/plain), 2.62 KB, created by
Lucas Gass (lukeg)
on 2025-07-25 17:17:39 UTC
(
hide
)
Description:
Bug 40114: Can't select new library when editing a desk
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-07-25 17:17:39 UTC
Size:
2.62 KB
patch
obsolete
>From 6496f384c9b2dab5cc1f88a439750c8b117cde0a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 10 Jun 2025 18:42:54 +0000 >Subject: [PATCH] Bug 40114: Can't select new library when editing a desk > >This patch fixes selection of a library when editing a desk in >Administration. The form should provide all libraries as options, not >just the currently selected one. > >To test, apply the patch and go to Administration -> Desks. > >- If necessary, create a new desk. >- Edit the desk. The form should load with the correct library prefilled > in the <select>, but should offer all libraries as a choices. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/admin/desks.tt | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt >index ef62959d0aa..13a9c1c8bdf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt >@@ -114,17 +114,10 @@ > <label for="branchcode" class="required">Library: </label> > <select id="branchcode" name="branchcode" required="required"> > <option value=""></option> >- [% FOREACH branch IN branches %] >- [% IF desk %] >- [% IF (desk.branchcode == branch.branchcode) %] >- <option value="[% branch.branchcode|html %]" selected="selected">[% branch.branchname|html %]</option> >- [% END %] >- [% ELSE %] >- [% IF (Branches.GetLoggedInBranchcode == branch.branchcode) %] >- <option value="[% branch.branchcode|html %]" selected="selected">[% branch.branchname|html %]</option> >- [% END %] >- <option value="[% branch.branchcode|html %]">[% branch.branchname|html %]</option> >- [% END %] >+ [% IF desk %] >+ [% PROCESS options_for_libraries libraries => Branches.all( selected => desk.branchcode ) %] >+ [% ELSE %] >+ [% PROCESS options_for_libraries libraries => Branches.all() %] > [% END %] > </select> > </li> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40114
:
183147
| 184656