Bugzilla – Attachment 18481 Details for
Bug 10331
Little errors in unimarc_field_4XX.pl (punctuation)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch - improved
0001-Bug-10331-Little-errors-in-unimarc_field_4XX.pl-punc.patch (text/plain), 2.96 KB, created by
Janusz Kaczmarek
on 2013-05-29 20:04:55 UTC
(
hide
)
Description:
Proposed patch - improved
Filename:
MIME Type:
Creator:
Janusz Kaczmarek
Created:
2013-05-29 20:04:55 UTC
Size:
2.96 KB
patch
obsolete
>From 2fe93fc61487eb92e8eb29628b30e92b67200a04 Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Fri, 24 May 2013 14:38:10 +0300 >Subject: [PATCH] Bug 10331 - Little errors in unimarc_field_4XX.pl (punctuation) > >--- > cataloguing/value_builder/unimarc_field_4XX.pl | 16 +++++++++++----- > 1 files changed, 11 insertions(+), 5 deletions(-) > >diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl >index e390010..75862cb 100755 >--- a/cataloguing/value_builder/unimarc_field_4XX.pl >+++ b/cataloguing/value_builder/unimarc_field_4XX.pl >@@ -116,16 +116,19 @@ sub plugin { > $subfield_value_a .= " " . $marcrecord->subfield( '700', "d" ) > if $marcrecord->subfield( '700', 'd' ); > $subfield_value_a .= >- " (" . $marcrecord->subfield( '700', 'c' ) . " - " >+ " (" . $marcrecord->subfield( '700', 'c' ) > if $marcrecord->subfield( '700', 'c' ); >+ $subfield_value_a .= " ; " >+ if $marcrecord->subfield( '700', 'c' ) >+ and $marcrecord->subfield( '700', 'f' ); > $subfield_value_a .= " (" > if ( $marcrecord->subfield( '700', 'f' ) > and not( $marcrecord->subfield( '700', 'c' ) ) ); > $subfield_value_a .= $marcrecord->subfield( '700', 'f' ) > if ( $marcrecord->subfield( '700', 'f' ) ); > $subfield_value_a .= ")" >- if ( $marcrecord->subfield( '701', 'f' ) >- or $marcrecord->subfield( '701', 'c' ) ); >+ if ( $marcrecord->subfield( '700', 'f' ) >+ or $marcrecord->subfield( '700', 'c' ) ); > } > elsif ( $marcrecord->field('702') ) { > $subfield_value_a = $marcrecord->subfield( '702', 'a' ); >@@ -134,8 +137,11 @@ sub plugin { > $subfield_value_a .= " " . $marcrecord->subfield( '702', 'd' ) > if $marcrecord->subfield( '702', 'd' ); > $subfield_value_a .= >- " (" . $marcrecord->subfield( '702', 'c' ) . "; " >+ " (" . $marcrecord->subfield( '702', 'c' ) > if $marcrecord->subfield( '702', 'c' ); >+ $subfield_value_a .= " ; " >+ if $marcrecord->subfield( '702', 'c' ) >+ and $marcrecord->subfield( '702', 'f' ); > $subfield_value_a .= " (" > if $marcrecord->subfield( '702', 'f' ) > and not $marcrecord->subfield( '702', 'c' ); >@@ -193,7 +199,7 @@ sub plugin { > " (" . $marcrecord->subfield( '712', 'f' ) . " - " > if $marcrecord->subfield( '712', 'f' ); > $subfield_value_a .= " (" >- if $marcrecord->field( '712', "e" ) >+ if $marcrecord->subfield( '712', "e" ) > and not $marcrecord->subfield( '712', 'f' ); > $subfield_value_a .= $marcrecord->subfield( '712', 'e' ) > if $marcrecord->subfield( '712', 'e' ); >-- >1.7.2.5 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=18481">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10331
:
18381
|
18481
|
20675
|
20676
|
20877