Bugzilla – Attachment 184824 Details for
Bug 40540
OPAC generates warnings in logs when no results are found
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40540: OPAC generates warnings in logs when no results are found
Bug-40540-OPAC-generates-warnings-in-logs-when-no-.patch (text/plain), 2.10 KB, created by
Roman Dolny
on 2025-07-29 15:31:27 UTC
(
hide
)
Description:
Bug 40540: OPAC generates warnings in logs when no results are found
Filename:
MIME Type:
Creator:
Roman Dolny
Created:
2025-07-29 15:31:27 UTC
Size:
2.10 KB
patch
obsolete
>From df5d343d41d2de83d80b386bc107dce8c76f445c Mon Sep 17 00:00:00 2001 >From: Janusz Kaczmarek <januszop@gmail.com> >Date: Tue, 29 Jul 2025 09:45:58 +0000 >Subject: [PATCH] Bug 40540: OPAC generates warnings in logs when no results > are found > >When no results are found, a warning: > >[WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 76. > >is generated in [plack-]opac-error.log > >Test plan: >========== >1. In OPAC, perform a search for a random string of characters to get no > results. >2. Check plack-opac-error.log. You should see a warning as above. >3. Apply the patch ; restart_all. >4. Repeat the search. Check the log -- there should be no new warning. > >Sponsored-by: Ignatianum University in Cracow >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 2713c1bf2b..dc154e054f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -73,7 +73,7 @@ > [% WRAPPER breadcrumb_item bc_active= 1 %] > [% IF ( ms_value ) %] > <span title="You searched [% IF ( query_desc ) %]for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %]with limit(s): '[% limit_desc | html %]'[% END %]" >- >Results of search for '[% ms_value | html %]'[% IF ( pages > 1) %], page [% current_page_number | html %] of [% pages | html %][% END %]</span >+ >Results of search for '[% ms_value | html %]'[% IF ( pages && pages > 1) %], page [% current_page_number | html %] of [% pages | html %][% END %]</span > > > [% ELSE %] > <span title="You searched [% IF ( query_desc ) %]for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %]with limit(s): '[% limit_desc | html %]'[% END %]">Search results</span> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40540
:
184788
|
184824
|
184971