Bugzilla – Attachment 184837 Details for
Bug 40542
Add `cancellation_reason` to holds strings embed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40542: Add strings embed to holds-related endpoints
Bug-40542-Add-strings-embed-to-holds-related-endpo.patch (text/plain), 2.06 KB, created by
David Nind
on 2025-07-29 18:01:32 UTC
(
hide
)
Description:
Bug 40542: Add strings embed to holds-related endpoints
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-07-29 18:01:32 UTC
Size:
2.06 KB
patch
obsolete
>From bada8466e20ba4a7f84a1dc7902c829978e19844 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 29 Jul 2025 11:17:42 -0300 >Subject: [PATCH] Bug 40542: Add strings embed to holds-related endpoints > >This patch makes holds endpoints be allowed to embed strings. > >To test: >1. Use your favourite REST tool to hit /api/v1/holds >2. Add the `x-koha-embed: +strings` header. >=> FAIL: The API rejects because it is not equiped with the feature. >3. Apply this patches >4. Run: > $ ktd --shell > k$ yarn api:bundle > k$ koha-plack --restart kohadev >5. Repeat 2 >=> SUCCESS: It works! >6. Sign off :-D > >Signed-off-by: David Nind <david@davidnind.com> >--- > api/v1/swagger/definitions/hold.yaml | 5 +++++ > api/v1/swagger/paths/holds.yaml | 1 + > api/v1/swagger/paths/patrons_holds.yaml | 1 + > 3 files changed, 7 insertions(+) > >diff --git a/api/v1/swagger/definitions/hold.yaml b/api/v1/swagger/definitions/hold.yaml >index 810f2647db0..af3cd550870 100644 >--- a/api/v1/swagger/definitions/hold.yaml >+++ b/api/v1/swagger/definitions/hold.yaml >@@ -135,5 +135,10 @@ properties: > - object > - "null" > description: Pickup library >+ _strings: >+ type: >+ - object >+ - "null" >+ description: A list of stringified coded values > > additionalProperties: false >diff --git a/api/v1/swagger/paths/holds.yaml b/api/v1/swagger/paths/holds.yaml >index 4fe775fb367..8181cfd0442 100644 >--- a/api/v1/swagger/paths/holds.yaml >+++ b/api/v1/swagger/paths/holds.yaml >@@ -101,6 +101,7 @@ > items: > type: string > enum: >+ - +strings > - cancellation_requested > - biblio > - deleted_biblio >diff --git a/api/v1/swagger/paths/patrons_holds.yaml b/api/v1/swagger/paths/patrons_holds.yaml >index 827cffd8bb8..af4623cd62e 100644 >--- a/api/v1/swagger/paths/patrons_holds.yaml >+++ b/api/v1/swagger/paths/patrons_holds.yaml >@@ -28,6 +28,7 @@ > items: > type: string > enum: >+ - +strings > - cancellation_requested > - biblio > - deleted_biblio >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40542
:
184810
|
184811
|
184836
|
184837
|
184881
|
184882
|
185074