Bugzilla – Attachment 184871 Details for
Bug 40529
Update how hold groups work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40529: Behavior change: Update old tests
Bug-40529-Behavior-change-Update-old-tests.patch (text/plain), 1.26 KB, created by
Pedro Amorim
on 2025-07-30 11:58:15 UTC
(
hide
)
Description:
Bug 40529: Behavior change: Update old tests
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-07-30 11:58:15 UTC
Size:
1.26 KB
patch
obsolete
>From a9d5bb7135658ba121453b7b5894924a8e04e63f Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Tue, 22 Jul 2025 12:26:27 +0000 >Subject: [PATCH] Bug 40529: Behavior change: Update old tests > >This is needed or the Reserves are created with a hold_group_id, which >will create a related hold_group and hold_group_target_holds. >As DisplayAddHoldGroups is considered to be enabled, it would otherwise skip >non-target holds and cause these tests to fail. >--- > t/db_dependent/Reserves.t | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t >index cced1feee76..16fb4c7ba57 100755 >--- a/t/db_dependent/Reserves.t >+++ b/t/db_dependent/Reserves.t >@@ -1279,6 +1279,7 @@ subtest 'CheckReserves additional tests' => sub { > suspend_until => undef, > suspend => 0, > itemtype => undef, >+ hold_group_id => undef, > } > } > ); >@@ -1299,6 +1300,7 @@ subtest 'CheckReserves additional tests' => sub { > suspend_until => undef, > suspend => 0, > itemtype => undef, >+ hold_group_id => undef, > } > } > ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40529
:
184868
|
184869
|
184870
|
184871
|
184872
|
185137
|
185138
|
185139
|
185140
|
185141
|
185210
|
185211
|
185212
|
185213
|
185214
|
185215
|
185303
|
185304
|
185305
|
185306
|
185307