Bugzilla – Attachment 184894 Details for
Bug 40554
Improve performance using a cache for AV descriptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40554: unsafe not used in set_in_cache
Bug-40554-unsafe-not-used-in-setincache.patch (text/plain), 805 bytes, created by
Jonathan Druart
on 2025-07-30 14:14:45 UTC
(
hide
)
Description:
Bug 40554: unsafe not used in set_in_cache
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-07-30 14:14:45 UTC
Size:
805 bytes
patch
obsolete
>From 7b612471a2faeae56e0793fe16643d4cd5398cf1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 30 Jul 2025 15:56:25 +0200 >Subject: [PATCH] Bug 40554: unsafe not used in set_in_cache > >--- > Koha/Cache.pm | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/Koha/Cache.pm b/Koha/Cache.pm >index 311743847ee..59c48d99893 100644 >--- a/Koha/Cache.pm >+++ b/Koha/Cache.pm >@@ -160,8 +160,6 @@ instance of C<Cache::*> and follow the same interface as L<Cache::Memcache>. > sub set_in_cache { > my ( $self, $key, $value, $options ) = @_; > >- my $unsafe = $options->{unsafe} || 0; >- > # the key mustn't contain whitespace (or control characters) for memcache > # but shouldn't be any harm in applying it globally. > $key =~ s/[\x00-\x20]/_/g; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40554
:
184893
| 184894 |
184895