Bugzilla – Attachment 184899 Details for
Bug 40556
Subfields names in control fields should not be displayed/editable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40556 - Subfields names in control fields should not be displayed/editable
Bug-40556---Subfields-names-in-control-fields-shou.patch (text/plain), 4.10 KB, created by
Baptiste Wojtkowski (bwoj)
on 2025-07-30 15:12:13 UTC
(
hide
)
Description:
Bug 40556 - Subfields names in control fields should not be displayed/editable
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2025-07-30 15:12:13 UTC
Size:
4.10 KB
patch
obsolete
>From ed088ef335c29db86e87690ba29b9f84aa2371c7 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Wed, 30 Jul 2025 17:08:51 +0200 >Subject: [PATCH] Bug 40556 - Subfields names in control fields should not be > displayed/editable > >In cataloguing/addbiblio.pl, there is a conditionnal display of the subfield name field. >However, it is depending on subfield_loo.fixedfield, which is never set up. However, the field corresponding information is available in innerloo.fixedfield. > ><input type="text" > title="[% subfield_loo.marc_lib | $raw %]" > style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]" > name="tag_[% subfield_loo.tag | html %]_code_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" > value="[% subfield_loo.subfield | html %]" > size="1" > >Moreover, following code does not make sense for control fields: > ><span class="handle"></span> > >TEST PLAN: >1 - Edit any record. Note that you can grab subfields, note you can edit > the 00 in the subfield input >2 - Apply patch >3 - On the same page, you should not be able to grab or edit subfield > titles. >--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 0748c11ee..e4db1176f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -1126,10 +1126,10 @@ > <!-- One line on the marc editor --> > <li class="subfield_line" style="[% subfield_loo.visibility | html %]" id="subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]"> > <div class="subfieldcode"> >- <span class="handle"></span> >+ [% UNLESS ( innerloo.fixedfield ) %] <span class="handle"></span> [% END %] > <input type="text" > title="[% subfield_loo.marc_lib | $raw %]" >- style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]" >+ style=" [% IF ( innerloo.fixedfield ) %]display:none; [% END %]" > name="tag_[% subfield_loo.tag | html %]_code_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" > value="[% subfield_loo.subfield | html %]" > size="1" >@@ -1145,7 +1145,7 @@ > [% ELSE %] > <div class="subfield"> > [% END %] >- [% IF ( subfield_loo.fixedfield ) %] >+ [% IF ( innerloo.fixedfield ) %] > <label for="tag_[% subfield_loo.tag | html %]_subfield_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" style="display:none;" class="labelsubfield"> > [% ELSE %] > <label for="tag_[% subfield_loo.tag | html %]_subfield_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" class="labelsubfield"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40556
: 184899