Bugzilla – Attachment 184905 Details for
Bug 40510
Add context to the word "More" in several templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40510: Add context to the word "More" in several templates
Bug-40510-Add-context-to-the-word-More-in-several-.patch (text/plain), 10.90 KB, created by
Owen Leonard
on 2025-07-30 16:13:15 UTC
(
hide
)
Description:
Bug 40510: Add context to the word "More" in several templates
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-07-30 16:13:15 UTC
Size:
10.90 KB
patch
obsolete
>From 1d45aa0517df821c1f66191d8041b457913b4582 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 30 Jul 2025 14:59:48 +0000 >Subject: [PATCH] Bug 40510: Add context to the word "More" in several > templates > >This patch updates several templates to use internationalization >template functions to add context to the word "More." This gives >translators information about the context of the word. > >To test, apply the patch and test that the correct strings are >translatable. In this example I'm testing fr-FR: > >- Update a translation: > >> gulp po:update >> cd misc/translator >> perl translate update fr-FR > >- Open the corresponding .po file for the strings which were > updated e.g. misc/translator/po/fr-FR-messages.po >- Locate instances of the string 'msgid "More"', for example: > > #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:308 > msgctxt "Show more information" > msgid "More" > msgstr "" > >- Edit each of the three instances of the "msgstr" string however you > want (it's just for testing) >- Install the updated translation: > >> perl translate install fr-FR > >- In the staff interface, switch to the updated translation and confirm > that your translations appear: > - In the header menu > - In the toolbar shown on a patron checkout or detail page > - In Acquisitions -> Invoices -> Invoice search results -> > - Click the invoice number > - Follow the "Go to receipt page" link > - If necessary, receive a pending order so that the "Already > received" table appears. > - Confirm that your translated string appears as a column header > - Go to Administration -> Identity providers > - Edit an identity provider > - Under "Advanced configuration" you should see your translated > string as a link to show more information about the fields. > - Click the "Manage domains" link for an identity provider. > - Edit a domain. > - You should see your translated string as a link to show more > information under the "Domain" field. > >Sponsored-by: Athens County Public Libraries >--- > koha-tmpl/intranet-tmpl/prog/en/includes/header.inc | 2 +- > .../intranet-tmpl/prog/en/includes/members-toolbar.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +- > .../prog/en/modules/admin/identity_provider_domains.tt | 4 ++-- > .../prog/en/modules/admin/identity_providers.tt | 8 ++++---- > 5 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >index 16ed39f758e..0634fd3492b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/header.inc >@@ -44,7 +44,7 @@ > [% Koha.Preference('IntranetNav') | $raw %] > <li class="nav-item dropdown"> > <a href="/cgi-bin/koha/mainpage.pl" class="nav-link dropdown-toggle" role="button" data-bs-toggle="dropdown" aria-expanded="false" >- ><span class="nav-link-icon"><i class="fa fa-fw fa-bars" title="More"></i></span> <span class="nav-link-text">More</span></a >+ ><span class="nav-link-icon"><i class="fa fa-fw fa-bars" title="[% tp('More menu options', 'More') | html %]"></i></span> <span class="nav-link-text">[% tp("More menu options", "More") | html %]</span></a > > > <ul class="dropdown-menu dropdown-menu-dark dropdown-menu-end"> > <li><a class="dropdown-item" href="/cgi-bin/koha/virtualshelves/shelves.pl">Lists</a></li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >index c40f34ebceb..62faf67702e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >@@ -73,7 +73,7 @@ > > [% IF CAN_user_borrowers_edit_borrowers %] > <div class="btn-group"> >- <button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown">More <span class="caret"></span></button> >+ <button class="btn btn-default dropdown-toggle" data-bs-toggle="dropdown">[% tp("More menu options", "More") | html %] <span class="caret"></span></button> > <ul class="dropdown-menu dropdown-menu-end"> > [% IF CAN_user_borrowers_edit_borrowers %] > <li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index 4dfc2d6ddef..410c55d95cb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -153,7 +153,7 @@ > <th>Order line</th> > <th title="Item holds / Total holds">Holds</th> > <th>Summary</th> >- <th class="no-sort">More</th> >+ <th class="no-sort">[% tp("Table column with more options", "More") | html %]</th> > <th>Replacement price</th> > <th>Quantity</th> > <th>Fund</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt >index 84d64a37320..46f79beba56 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt >@@ -98,7 +98,7 @@ > <label for="domain">Domain: </label> > <input type="text" name="domain" id="domain" size="60" /> > <div class="hint" >- >Email domain to match this rule. <button class="more btn btn-ligth" data-bs-target="domain"><i class="fa fa-caret-down"></i> More</button></div >+ >Email domain to match this rule. <button class="more btn btn-ligth" data-bs-target="domain"><i class="fa fa-caret-down"></i> [% tp("Show more information", "More") | html %]</button></div > > > <div class="hint more-domain" style="display: none"> > <p>If this field is empty, or '*' any email domain will match this rule.</p> >@@ -182,7 +182,7 @@ > <label for="domain">Domain: </label> > <input type="text" name="domain" id="domain" size="60" value="[%- identity_provider_domain.domain | html -%]" /> > <div class="hint" >- >Email domain to match this rule. <button class="more btn btn-ligth" data-bs-target="domain"><i class="fa fa-caret-down"></i> More</button></div >+ >Email domain to match this rule. <button class="more btn btn-ligth" data-bs-target="domain"><i class="fa fa-caret-down"></i> [% tp("Show more information", "More") | html %]</button></div > > > <div class="hint more-domain" style="display: none"> > <p>If this field is empty, or '*' any email domain will match this rule.</p> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt >index a02a3e300fc..af0762120c8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt >@@ -121,7 +121,7 @@ > <textarea name="config" id="config" class="required" cols="75" rows="10"></textarea> > <span class="required">Required</span> > <div class="hint" >- >Provider's main configuration. <button class="more btn btn-light" data-target="config"><i class="fa fa-caret-down"></i> More</button></div >+ >Provider's main configuration. <button class="more btn btn-light" data-target="config"><i class="fa fa-caret-down"></i> [% tp("Show more information", "More") | html %]</button></div > > > <div class="hint more-config" style="display: none"> > <div>This configuration differs for each protocol.</div> >@@ -136,7 +136,7 @@ > <textarea name="mapping" id="mapping" class="required" cols="75" rows="10"></textarea> > <span class="required">Required</span> > <div class="hint" >- >Map provider's result to Koha patron's fields. <button class="more btn btn-light" data-target="mapping"><i class="fa fa-caret-down"></i> More</button></div >+ >Map provider's result to Koha patron's fields. <button class="more btn btn-light" data-target="mapping"><i class="fa fa-caret-down"></i> [% tp("Show more information", "More") | html %]</button></div > > > <div class="hint more-mapping" style="display: none"> > <div>It is recommended to add the default mapping, and then modify to suit this provider's response</div> >@@ -290,7 +290,7 @@ > <textarea name="config" id="config" class="required" cols="75" rows="10">[%- identity_provider.config | html -%]</textarea> > <span class="required">Required</span> > <div class="hint" >- >Provider's main configuration. <button class="more btn btn-light" data-target="config"><i class="fa fa-caret-down"></i> More</button></div >+ >Provider's main configuration. <button class="more btn btn-light" data-target="config"><i class="fa fa-caret-down"></i> [% tp("Show more information", "More") | html %]</button></div > > > <div class="hint more-config" style="display: none"> > <div>This configuration differs for each protocol.</div> >@@ -305,7 +305,7 @@ > <textarea name="mapping" id="mapping" class="required" cols="75" rows="10">[%- identity_provider.mapping | html -%]</textarea> > <span class="required">Required</span> > <div class="hint" >- >Map provider's result to Koha patron's fields. <button class="more btn btn-light" data-target="mapping"><i class="fa fa-caret-down"></i> More</button></div >+ >Map provider's result to Koha patron's fields. <button class="more btn btn-light" data-target="mapping"><i class="fa fa-caret-down"></i> [% tp("Show more information", "More") | html %]</button></div > > > <div class="hint more-mapping" style="display: none"> > <div>It is recommended to add the default mapping, and then modify to suit this provider's response</div> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40510
: 184905