Bugzilla – Attachment 184917 Details for
Bug 28530
Allow configuration of floating limits by item type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28530: Subtract outgoing transfers from the branches float limit
Bug-28530-Subtract-outgoing-transfers-from-the-bra.patch (text/plain), 4.29 KB, created by
Lucas Gass (lukeg)
on 2025-07-30 22:05:15 UTC
(
hide
)
Description:
Bug 28530: Subtract outgoing transfers from the branches float limit
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-07-30 22:05:15 UTC
Size:
4.29 KB
patch
obsolete
>From 737500e3402998c3f062ddbc26c727d73d2392a2 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 30 Jul 2025 22:03:44 +0000 >Subject: [PATCH] Bug 28530: Subtract outgoing transfers from the branches > float limit > >--- > C4/Circulation.pm | 2 +- > Koha/Library/FloatLimits.pm | 42 +++++++++++++++++++++++++++++++++---- > 2 files changed, 39 insertions(+), 5 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 0084d4b1b80..145f7b222bd 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2281,7 +2281,7 @@ sub AddReturn { > my $count = Koha::Items->count( { itype => $limit->itemtype, holdingbranch => $branch } ); > if ( $count >= $limit->float_limit ) { > my $transfer_library = Koha::Library::FloatLimits->lowest_ratio_library( $item, $branch ); >- if ( $transfer_library->branchcode ne $branch ) { >+ if ( $transfer_library && $transfer_library->branchcode ne $branch ) { > $returnbranch = $transfer_library->branchcode; > $transfer_trigger = 'LibraryFloatLimit'; > } >diff --git a/Koha/Library/FloatLimits.pm b/Koha/Library/FloatLimits.pm >index 066d88ca96d..db611314f18 100644 >--- a/Koha/Library/FloatLimits.pm >+++ b/Koha/Library/FloatLimits.pm >@@ -60,6 +60,9 @@ sub lowest_ratio_library { > my $branch = $limit->get_column('branchcode'); > my $float_limit_val = $limit->get_column('float_limit'); > >+ #don't try to transfer something to where it already is >+ next if $branch eq $branchcode; >+ > my $item_count; > > if ($use_item_level) { >@@ -72,7 +75,7 @@ sub lowest_ratio_library { > )->count; > > # Count items in transit TO this branch >- my $in_transit_count = Koha::Items->search( >+ my $in_transit_to_count = Koha::Items->search( > { > itype => $item->effective_itemtype, > >@@ -88,7 +91,20 @@ sub lowest_ratio_library { > distinct => 1 > } > )->count; >- $item_count = $at_branch_count + $in_transit_count; >+ >+ my $in_transit_from_count = Koha::Items->search( >+ { itype => $item->effective_itemtype }, >+ { >+ join => 'branchtransfers', >+ where => { >+ 'branchtransfers.frombranch' => $branch, >+ 'branchtransfers.datearrived' => undef, >+ 'branchtransfers.datecancelled' => undef, >+ }, >+ distinct => 1 >+ } >+ )->count; >+ $item_count = $at_branch_count + $in_transit_to_count - $in_transit_from_count; > } else { > my $at_branch_count = Koha::Items->search( > { >@@ -99,7 +115,7 @@ sub lowest_ratio_library { > )->count; > > # Count items in transit TO this branch >- my $in_transit_count = Koha::Items->search( >+ my $in_transit_to_count = Koha::Items->search( > { > itype => $item->effective_itemtype, > }, >@@ -113,9 +129,27 @@ sub lowest_ratio_library { > distinct => 1 > } > )->count; >- $item_count = $at_branch_count + $in_transit_count; >+ >+ my $in_transit_from_count = Koha::Items->search( >+ { >+ itype => $item->effective_itemtype, >+ }, >+ { >+ join => 'branchtransfers', >+ where => { >+ 'branchtransfers.frombranch' => $branch, >+ 'branchtransfers.datearrived' => undef, # Still in transit >+ 'branchtransfers.datecancelled' => undef, #Not cancelled >+ }, >+ distinct => 1 >+ } >+ )->count; >+ $item_count = $at_branch_count + $in_transit_to_count - $in_transit_from_count; > } > >+ #don't transfer to branches that are already at their float limit >+ next if $item_count >= $float_limit_val; >+ > my $ratio = $item_count / $float_limit_val; > push @candidates, { > branchcode => $branch, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28530
:
160038
|
160039
|
160040
|
160041
|
160042
|
160043
|
160044
|
160045
|
160046
|
160047
|
160048
|
160049
|
160050
|
160053
|
160054
|
160055
|
160056
|
160057
|
160058
|
160061
|
160062
|
160063
|
160064
|
160065
|
160066
|
160067
|
160068
|
160071
|
160072
|
160073
|
160074
|
160075
|
160076
|
160077
|
160078
|
160079
|
160080
|
160081
|
160082
|
160083
|
160084
|
163919
|
168343
|
168344
|
168345
|
168346
|
168347
|
168348
|
168349
|
168350
|
178762
|
178763
|
178764
|
178765
|
178766
|
178767
|
178768
|
178769
|
178783
|
178784
|
178785
|
178934
|
178935
|
178936
|
178937
|
178938
|
178939
|
178940
|
178941
|
178942
|
178943
|
178944
|
178945
|
178946
|
179943
|
179944
|
179945
|
179946
|
179947
|
179948
|
179949
|
179950
|
179951
|
179952
|
179953
|
179954
|
179955
|
180028
|
182931
|
184754
|
184755
|
184917
|
184936
|
184951
|
184952
|
184953
|
184954
|
184955
|
184956
|
184957
|
184958
|
184959
|
184960
|
184961
|
184963
|
184965
|
184966
|
184967
|
185038
|
185836
|
185837
|
185838
|
185839
|
185840
|
185841
|
185842
|
185843