Bugzilla – Attachment 185045 Details for
Bug 40026
Edit item metadata should present Standard form if AutoILLBackendPriority is in use
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40026: (QA follow-up): Only compare string if defined
Bug-40026-QA-follow-up-Only-compare-string-if-defi.patch (text/plain), 1.10 KB, created by
Nick Clemens (kidclamp)
on 2025-08-01 16:00:15 UTC
(
hide
)
Description:
Bug 40026: (QA follow-up): Only compare string if defined
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-08-01 16:00:15 UTC
Size:
1.10 KB
patch
obsolete
>From 95e9dddd66e95dc904aa3bf432bbd6eec964dd25 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Fri, 1 Aug 2025 15:55:16 +0000 >Subject: [PATCH] Bug 40026: (QA follow-up): Only compare string if defined > >prove /kohadevbox/koha/t/db_dependent/Koha/ILL/Requests.t > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/ILL/Request.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 42a563d8b04..3816afce85a 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -1161,8 +1161,10 @@ sub expand_template { > my ( $self, $params ) = @_; > my $backend = $self->_backend->name; > >- if ( $backend eq 'Standard' >- || ( $params->{method} eq 'edititem' && C4::Context->preference("AutoILLBackendPriority") ) ) >+ if ( >+ $backend eq 'Standard' >+ || ( $params->{method} && $params->{method} eq 'edititem' && C4::Context->preference("AutoILLBackendPriority") ) >+ ) > { > > my $template_name = 'ill/backends/Standard/' . ( $params->{method} // q{} ) . '.inc'; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40026
:
182836
|
182837
|
182838
|
182898
|
182899
|
182900
|
183276
|
183277
|
183278
|
183289
|
183290
|
183291
|
185039
|
185040
|
185041
|
185044
| 185045