Bugzilla – Attachment 185049 Details for
Bug 39917
Display a prompt for status alias when completing a request if ILL_STATUS_ALIAS in use
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39917: (QA follow-up) Correct spelling and remove <p> tag around form
Bug-39917-QA-follow-up-Correct-spelling-and-remove.patch (text/plain), 4.12 KB, created by
Nick Clemens (kidclamp)
on 2025-08-01 16:10:56 UTC
(
hide
)
Description:
Bug 39917: (QA follow-up) Correct spelling and remove <p> tag around form
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-08-01 16:10:56 UTC
Size:
4.12 KB
patch
obsolete
>From bc4cd3c4d2126868730c420c26c235375d0bd574 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 1 Aug 2025 16:08:06 +0000 >Subject: [PATCH] Bug 39917: (QA follow-up) Correct spelling and remove <p> tag > around form > >QA tools complained >--- > .../prog/en/modules/ill/ill-requests.tt | 36 +++++++++---------- > t/db_dependent/Koha/ILL/Requests.t | 2 +- > 2 files changed, 18 insertions(+), 20 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index ecd6eb56591..a8bd0f4d995 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -121,25 +121,23 @@ > <h1>Complete ILL request</h1> > <p>Proceeding with this action will set this request to 'Completed'.</p> > <p>You can select a status alias from the available options:</p> >- <p> >- [% base_url = "/cgi-bin/koha/ill/ill-requests.pl" %] >- [% proceed_url = base_url _ "?method=mark_completed&stage=complete" _ "&illrequest_id=" _ request.illrequest_id %] >- <form action="[% proceed_url | url %]" method="get"> >- <select name="status_alias"> >- <option value="" selected></option> >- [% FOREACH alias IN AuthorisedValues.Get('ILL_STATUS_ALIAS') %] >- <option value="[% alias.authorised_value | html %]" > [% alias.lib | html %] </option> >- [% END %] >- </select> >- <input type="hidden" name="method" value="mark_completed"> >- <input type="hidden" name="stage" value="complete"> >- <input type="hidden" name="illrequest_id" value="[% request.illrequest_id | html%]"> >- <fieldset class="action"> >- <button type="submit" class="btn btn-sm btn-primary">Complete request</button> >- <a class="btn btn-sm btn-default cancel" href="[% base_url | url %]">Cancel</a> >- </fieldset> >- </form> >- </p> >+ [% base_url = "/cgi-bin/koha/ill/ill-requests.pl" %] >+ [% proceed_url = base_url _ "?method=mark_completed&stage=complete" _ "&illrequest_id=" _ request.illrequest_id %] >+ <form action="[% proceed_url | url %]" method="get"> >+ <select name="status_alias"> >+ <option value="" selected></option> >+ [% FOREACH alias IN AuthorisedValues.Get('ILL_STATUS_ALIAS') %] >+ <option value="[% alias.authorised_value | html %]"> [% alias.lib | html %] </option> >+ [% END %] >+ </select> >+ <input type="hidden" name="method" value="mark_completed" /> >+ <input type="hidden" name="stage" value="complete" /> >+ <input type="hidden" name="illrequest_id" value="[% request.illrequest_id | html %]" /> >+ <fieldset class="action"> >+ <button type="submit" class="btn btn-sm btn-primary">Complete request</button> >+ <a class="btn btn-sm btn-default cancel" href="[% base_url | url %]">Cancel</a> >+ </fieldset> >+ </form> > [% ELSIF op == 'cud-cancel' and !whole.error %] > <h1>Cancel a confirmed request</h1> > [% PROCESS $whole.template %] >diff --git a/t/db_dependent/Koha/ILL/Requests.t b/t/db_dependent/Koha/ILL/Requests.t >index 2f6f8a36690..29e368ba981 100755 >--- a/t/db_dependent/Koha/ILL/Requests.t >+++ b/t/db_dependent/Koha/ILL/Requests.t >@@ -194,7 +194,7 @@ subtest 'Basic object tests' => sub { > > isnt( > $illrq_obj->status, 'COMP', >- "ILL_STATUS_ALIAS is not empty. ILL is not immediatelly complete." >+ "ILL_STATUS_ALIAS is not empty. ILL is not immediately complete." > ); > > is( >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39917
:
182517
|
182518
|
182541
|
183091
|
183092
|
183093
|
185046
|
185047
|
185048
| 185049