Bugzilla – Attachment 185096 Details for
Bug 40262
ILL - Save the fact that copyright clearance has been confirmed by the patron
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40262: (QA follow-up): Fix compatibility with ILLOpacUnauthenticatedRequest
Bug-40262-QA-follow-up-Fix-compatibility-with-ILLO.patch (text/plain), 4.06 KB, created by
Pedro Amorim
on 2025-08-04 12:08:21 UTC
(
hide
)
Description:
Bug 40262: (QA follow-up): Fix compatibility with ILLOpacUnauthenticatedRequest
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-08-04 12:08:21 UTC
Size:
4.06 KB
patch
obsolete
>From 688f43a11d426e2e60947b5c2a16f58f228f80e0 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Mon, 4 Aug 2025 12:01:46 +0000 >Subject: [PATCH] Bug 40262: (QA follow-up): Fix compatibility with > ILLOpacUnauthenticatedRequest > >This patch fixes the copyrightclearance_confirmed not saving if submitting an unauthenticated ILL request. >--- > .../prog/en/modules/ill/ill-requests.tt | 8 ++++---- > opac/opac-illrequests.pl | 17 +++++++++-------- > 2 files changed, 13 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index 9d05388f496..1c0f9e7f108 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -616,6 +616,10 @@ > <div class="page-section"> > <h3>Request details</h3> > <h4>Details from library</h4> >+ [% copyrightclearance_confirmed = request.extended_attributes.find({'type'=>'copyrightclearance_confirmed'}).value %] >+ [% IF copyrightclearance_confirmed %] >+ <h5> <i class="fa fa-fw fa-check text-success" aria-hidden="true"></i> <span class="tab-title">Patron has confirmed copyright clearance for this request</span> </h5> >+ [% END %] > <div class="rows"> > <ol> > [% IF request.orderid %] >@@ -629,10 +633,6 @@ > <span class="label borrowernumber">Patron:</span> > [% borrowerlink = "/cgi-bin/koha/members/moremember.pl" _ "?borrowernumber=" _ request.patron.borrowernumber %] > <a href="[% borrowerlink | url %]" title="View borrower details"> [% request.patron.firstname _ " " _ request.patron.surname _ " [" _ request.patron.cardnumber _ "]" | html %] </a> >- [% copyrightclearance_confirmed = request.extended_attributes.find({'type'=>'copyrightclearance_confirmed'}).value %] >- [% IF copyrightclearance_confirmed %] >- <i class="fa fa-fw fa-check text-success" aria-hidden="true"></i> <span class="tab-title">Patron has confirmed copyright clearance for this request</span> >- [% END %] > </li> > [% END %] > [% IF request.biblio_id %] >diff --git a/opac/opac-illrequests.pl b/opac/opac-illrequests.pl >index f60c948ec64..0982584c6c3 100755 >--- a/opac/opac-illrequests.pl >+++ b/opac/opac-illrequests.pl >@@ -200,6 +200,15 @@ if ( $op eq 'list' ) { > ); > if ( $backend_result->{stage} eq 'commit' ) { > >+ $request->extended_attributes( >+ [ >+ { >+ type => 'copyrightclearance_confirmed', >+ value => 1, >+ } >+ ] >+ ) if $params->{copyrightclearance_confirmed}; >+ > # After creation actions > if ( $params->{type_disclaimer_submitted} ) { > $type_disclaimer->after_request_created( $params, $request ); >@@ -233,14 +242,6 @@ if ( $op eq 'list' ) { > $session->flush; > print $query->redirect('/cgi-bin/koha/opac-illrequests-unauthenticated.pl'); > } else { >- $request->extended_attributes( >- [ >- { >- type => 'copyrightclearance_confirmed', >- value => 1, >- } >- ] >- ) if $params->{copyrightclearance_confirmed}; > print $query->redirect('/cgi-bin/koha/opac-illrequests.pl?message=2'); > exit; > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40262
:
183607
|
183662
| 185096