Bugzilla – Attachment 185117 Details for
Bug 30915
"Scalar" TT plugin no longer needed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30915: (QA follow-up) Add warning for notices with Context.Scalar
Bug-30915-QA-follow-up-Add-warning-for-notices-wit.patch (text/plain), 1.79 KB, created by
Marcel de Rooy
on 2025-08-05 12:17:02 UTC
(
hide
)
Description:
Bug 30915: (QA follow-up) Add warning for notices with Context.Scalar
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-08-05 12:17:02 UTC
Size:
1.79 KB
patch
obsolete
>From 4141333de251c1ff1cbe56d7ccbef1a3b892843d Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 5 Aug 2025 14:00:31 +0200 >Subject: [PATCH] Bug 30915: (QA follow-up) Add warning for notices with > Context.Scalar >Content-Type: text/plain; charset=utf-8 > >As requested on comment4. > >Test plan: >Run the dbrev. >Bonus: Add a Context.Scalar construct in a notice and rerun. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../data/mysql/atomicupdate/bug_30915.pl | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > create mode 100755 installer/data/mysql/atomicupdate/bug_30915.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_30915.pl b/installer/data/mysql/atomicupdate/bug_30915.pl >new file mode 100755 >index 0000000000..8b11bd7f2b >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_30915.pl >@@ -0,0 +1,25 @@ >+use Modern::Perl; >+use Koha::Installer::Output qw(say_warning say_success say_info); >+ >+return { >+ bug_number => 30915, >+ description => "Warn for use of Context.Scalar in notices", >+ up => sub { >+ my ($args) = @_; >+ my ( $dbh, $out ) = @$args{qw(dbh out)}; >+ >+ my $notices = $dbh->selectcol_arrayref( >+ q{ >+ SELECT code FROM letter WHERE content LIKE '%Context.Scalar%' >+ } >+ ); >+ if (@$notices) { >+ say_warning( >+ $out, >+ q|We discovered that your notices as mentioned below are still using Context.Scalar. Please adjust them by following the instructions on Bugzilla report 30915. In most cases [% Context.Scalar($x,$y) %] should simply be [% $x.$y %].| >+ . qq|\nWe found the following notices: | >+ . join( ', ', @$notices ) . q|.| >+ ); >+ } >+ }, >+}; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30915
:
184468
|
184469
|
185108
|
185109
| 185117