Bugzilla – Attachment 185161 Details for
Bug 39802
Add CircControl equivalent system preference for lost item fees and actions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39802: Use new preference in longoverdue cron
Bug-39802-Use-new-preference-in-longoverdue-cron.patch (text/plain), 1.69 KB, created by
Nick Clemens (kidclamp)
on 2025-08-06 15:22:28 UTC
(
hide
)
Description:
Bug 39802: Use new preference in longoverdue cron
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-08-06 15:22:28 UTC
Size:
1.69 KB
patch
obsolete
>From f82513460c7dc58cb5b740d6cf412c1cc72c27e5 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 6 Aug 2025 15:10:06 +0000 >Subject: [PATCH] Bug 39802: Use new preference in longoverdue cron > >The test plan here is largely confirming that nothing has changed. > >Using CircControl here has an existing problem - when set to 'PickupLibrary' >the check in this cron looks for items from the userenv branch - the cron doesn't >have a userenv branch, it is undef, so for any library limiting by branch and >with CircControl set to 'PickupLibrary' / 'the library you are logged in at' the cron will do nothing >--- > misc/cronjobs/longoverdue.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/longoverdue.pl b/misc/cronjobs/longoverdue.pl >index d23df572bee..e41862306d7 100755 >--- a/misc/cronjobs/longoverdue.pl >+++ b/misc/cronjobs/longoverdue.pl >@@ -360,7 +360,7 @@ sub longoverdue_sth { > } > > my $dbh = C4::Context->dbh; >-my $circ_control_pref = C4::Context->preference('CircControl'); >+my $lost_control_pref = C4::Context->preference('LostChargesControl'); > my $home_holding_pref = C4::Context->preference('HomeOrHoldingBranch'); > > my @available_categories = Koha::Patron::Categories->search()->get_column('categorycode'); >@@ -482,7 +482,7 @@ foreach my $startrange ( sort keys %$lost ) { > } > if ($filter_branches) { > my $lib; >- for ($circ_control_pref) { >+ for ($lost_control_pref) { > if ( $_ eq 'PatronLibrary' ) { > $patron ||= Koha::Patrons->find( $row->{borrowernumber} ); > $lib = $patron->branchcode(); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39802
:
185160
| 185161 |
185162
|
185165