Attachment 1852 Details for Bug 4123 – This patch adds the code. Fixed our problem being unable to renew items.

[patch] This patch adds the code. Fixed our problem being unable to renew items.

0001-Bugfix-4123-CanBookBeRenewed-fixed.patch (text/plain), 1.18 KB, created by Chris Cormack on 2010-03-01 17:06:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2010-03-01 17:06:00 UTC

Size: 1.18 KB

patch

obsolete

>From fa5a840d46642168d1ed9b72e10bb91b8c776405 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle.m.hall@gmail.com>
>Date: Mon, 1 Mar 2010 11:57:29 -0500
>Subject: [PATCH] Bugfix 4123 - CanBookBeRenewed fixed.
>
>In Circulation::CanBookBeRenewed categorycode and itemtype were not being checked for * wildcard
>if a specific code was not given.
>---
> C4/Circulation.pm |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 98f324c..6ff6f8e 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -2060,9 +2060,9 @@ sub CanBookBeRenewed {
>                    LEFT JOIN biblioitems USING (biblioitemnumber)
>                    
>                    WHERE
>-                    issuingrules.categorycode = borrowers.categorycode
>+                    (issuingrules.categorycode = borrowers.categorycode OR issuingrules.categorycode = '*')
>                    AND
>-                    issuingrules.itemtype = $itype
>+                    (issuingrules.itemtype = $itype OR issuingrules.itemtype = '*')
>                    AND
>                     (issuingrules.branchcode = $controlbranch OR issuingrules.branchcode = '*') 
>                    AND 
>-- 
>1.5.6.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 4123: 1852