Bugzilla – Attachment 185206 Details for
Bug 17656
Irregularities in serial prediction pattern are planned only for current subscription
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17656: (QA follow-up) fix templates
Bug-17656-QA-follow-up-fix-templates.patch (text/plain), 6.67 KB, created by
Arthur Suzuki
on 2025-08-07 09:38:15 UTC
(
hide
)
Description:
Bug 17656: (QA follow-up) fix templates
Filename:
MIME Type:
Creator:
Arthur Suzuki
Created:
2025-08-07 09:38:15 UTC
Size:
6.67 KB
patch
obsolete
>From 7c0e169e1081bf8ebb1fac548ee436e62ef870ce Mon Sep 17 00:00:00 2001 >From: Arthur Suzuki <arthur.suzuki@biblibre.com> >Date: Thu, 7 Aug 2025 09:18:44 +0000 >Subject: [PATCH] Bug 17656: (QA follow-up) fix templates > >--- > koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc | 1 + > .../prog/en/includes/serials/subscription_daily_choice.inc | 2 +- > .../en/includes/serials/subscription_monthly_choice.inc | 2 +- > .../en/includes/serials/subscription_weekly_choice.inc | 2 +- > .../prog/en/modules/serials/subscription-add.tt | 2 +- > .../prog/en/modules/serials/subscription-renew.tt | 7 +++++-- > 6 files changed, 10 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >index 681e8cc4013..9b056feb232 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc >@@ -201,6 +201,7 @@ > let refresh_max_date = 0; > let disable_buttons = []; > >+ options['defaultDate'] = $(input).val(); > if( $(input).data("flatpickr-futureinclusive") === true > || $(input).data("flatpickr-futuredate") === true ) { > let original_date = $(input).val(); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc >index 8cae6657d7c..3e49f952f84 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc >@@ -28,7 +28,7 @@ > <label for="[% day.name | html %]" class="inline">[% PROCESS days d=day.name %]</label> > [% END %] > <p> >- <em>Check days in the above list in order to keep them unpublished troughout upcoming renewals (permanent irregularities).</em> >+ <em>Check days in the above list in order to keep them unpublished throughout upcoming renewals (permanent irregularities).</em> > </p> > <p> > <em>Or check days in the "Not published" column below to set unpublished days for this subscription only.</em> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc >index 4add5947eb9..ad68360dab5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc >@@ -38,7 +38,7 @@ > <label for="[% month.name | html %]" class="inline">[% PROCESS months m=month.name %]</label> > [% END %] > <p> >- <em>Check months in the above list in order to keep them unpublished troughout upcoming renewals (permanent irregularities).</em> >+ <em>Check months in the above list in order to keep them unpublished throughout upcoming renewals (permanent irregularities).</em> > </p> > <p> > <em>Or check months in the "Not published" column below to set unpublished months for this subscription only.</em> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_weekly_choice.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_weekly_choice.inc >index 610cb5d4a33..af552e9cc4e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_weekly_choice.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_weekly_choice.inc >@@ -23,7 +23,7 @@ > </div> > </div> > <p> >- <em>Check weeks in the above list in order to keep them unpublished troughout upcoming renewals (permanent irregularities).</em> >+ <em>Check weeks in the above list in order to keep them unpublished throughout upcoming renewals (permanent irregularities).</em> > </p> > <p> > <em>Or check weeks in the "Not published" column below to set unpublished weeks for this subscription only.</em> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >index e2ad9252767..587a5cc0068 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >@@ -379,7 +379,7 @@ > <select name="numbering_pattern" id="numberpattern" class="required" required="required"> > <option value="">-- please choose --</option> > [% FOREACH numberpattern IN numberpatterns %] >- <option value="[% numberpattern.id | html %]" [% IF numberpattern.selected %]selected="selected"[% END %]> </option> >+ <option value="[% numberpattern.id | html %]" [% IF numberpattern.selected %]selected="selected"[% END %]>[% numberpattern.label | html %]</option> > [% END %] > </select> > <span class="required">Required</span> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >index c05fb8c371d..c859643ca6d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >@@ -97,7 +97,7 @@ > <ol> > <li> > <label for="startdate">Start date: </label> >- <input type="text" size="10" id="startdate" name="startdate" value="[% startdate | html %]" class="flatpickr" /> >+ <input type="text" size="10" id="startdate" name="startdate" class="flatpickr" value="[% startdate | html %]" /> > <div class="hint">[% INCLUDE 'date-format.inc' %]</div> > </li> > <li> >@@ -106,7 +106,10 @@ > [% FOREACH st IN [['numberlength', 'issues'], ['weeklength', 'weeks'], ['monthlength', 'months']] %] > [% SET subtype = st.0 %] > [% SET value = st.1 %] >- <option value="[% value | html %]" [% IF subscription.$subtype %]selected="selected"[% END %]> >+ <option value="[% value | html %]" >+ [% IF subscription.$subtype %] >+ selected="selected" >+ [% END %]> > [% SWITCH subtype %] > [% CASE 'numberlength' %] > <span>issues</span> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17656
:
68259
|
68261
|
68607
|
68608
|
68665
|
69124
|
69207
|
69279
|
69553
|
69814
|
69820
|
69915
|
70335
|
70336
|
70430
|
70619
|
75403
|
75404
|
75405
|
75406
|
75407
|
75408
|
75721
|
75722
|
75723
|
75724
|
75725
|
75726
|
75953
|
102724
|
102725
|
102726
|
102727
|
102728
|
102729
|
102730
|
102860
|
102861
|
102862
|
102863
|
102864
|
102865
|
102866
|
102867
|
102960
|
102961
|
102962
|
102963
|
102964
|
102965
|
102966
|
102967
|
102968
|
103623
|
103624
|
103625
|
103626
|
103627
|
103628
|
103629
|
103630
|
103631
|
103657
|
103658
|
103659
|
103660
|
103661
|
103662
|
103663
|
103664
|
103665
|
103667
|
117789
|
117790
|
117791
|
117792
|
117846
|
117851
|
117852
|
118856
|
119106
|
120863
|
121082
|
121083
|
121084
|
121085
|
121086
|
121087
|
121088
|
121192
|
121193
|
121194
|
121195
|
121196
|
121197
|
121198
|
121296
|
121297
|
121298
|
121299
|
121300
|
121301
|
121302
|
128489
|
128491
|
128492
|
128493
|
128494
|
128495
|
128496
|
128498
|
128499
|
128500
|
128501
|
128502
|
128503
|
128504
|
132412
|
132413
|
132415
|
132416
|
132417
|
132418
|
132447
|
132448
|
132692
|
132779
|
177497
|
177498
|
177499
|
177500
|
177501
|
177502
|
177503
|
177504
|
177505
|
177663
|
177664
|
177665
|
177666
|
177667
|
177668
|
177669
|
177670
|
177671
|
177831
|
177832
|
177833
|
177834
|
177835
|
177836
|
177837
|
177838
|
177839
|
178142
|
185196
|
185197
|
185198
|
185199
|
185200
|
185201
|
185202
|
185203
|
185204
|
185205
| 185206 |
185207
|
185208