Bugzilla – Attachment 185259 Details for
Bug 40608
Password not changed if PASSWORD_CHANGE letter absent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40608: (follow-up) Add warning in about page
Bug-40608-follow-up-Add-warning-in-about-page.patch (text/plain), 7.14 KB, created by
Marcel de Rooy
on 2025-08-08 07:01:42 UTC
(
hide
)
Description:
Bug 40608: (follow-up) Add warning in about page
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-08-08 07:01:42 UTC
Size:
7.14 KB
patch
obsolete
>From b5f3a68512554796f183cb4db857f828e0dee2f8 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 7 Aug 2025 16:10:36 -0300 >Subject: [PATCH] Bug 40608: (follow-up) Add warning in about page >Content-Type: text/plain; charset=utf-8 > >This patch adds a check in about.pl for when `NotifyPasswordChange` is >enabled but no notices are present on the system. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > about.pl | 14 ++++++++++++++ > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 13 +++++++++++-- > 2 files changed, 25 insertions(+), 2 deletions(-) > >diff --git a/about.pl b/about.pl >index 7f8f113425..788ad2f112 100755 >--- a/about.pl >+++ b/about.pl >@@ -49,6 +49,7 @@ use Koha::BiblioFrameworks; > use Koha::Biblios; > use Koha::Email; > use Koha::I18N; >+use Koha::Notice::Templates; > use Koha::Patron::Categories; > use Koha::Patrons; > use Koha::Caches; >@@ -588,6 +589,19 @@ if ( $tab eq 'sysinfo' ) { > $template->param( warnDbRowFormat => C4::Installer->has_non_dynamic_row_format ); > } > >+ # NotifyPasswordChange >+ if ( C4::Context->preference('NotifyPasswordChange') ) { >+ >+ $template->param( warnPassChangeNoticeMissing => 1 ) >+ unless Koha::Notice::Templates->find_effective_template( >+ { >+ module => 'members', >+ code => 'PASSWORD_CHANGE', >+ message_transport_type => 'email', >+ } >+ ); >+ } >+ > $template->param( > prefRequireChoosingExistingAuthority => $prefRequireChoosingExistingAuthority, > prefAutoCreateAuthorities => $prefAutoCreateAuthorities, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 3cd1bba40b..1fd0a5cc61 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -328,7 +328,7 @@ > [% SET warnMissingCompiledFiles = 1 %] > [% END %] > [% WRAPPER tab_panel tabname= "sysinfo" bt_active = 1 %] >- [% IF weasyprint_missing || warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || warnPrefPatronSelfRegistrationDefaultCategory || invalid_yesno.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || warnI18nMissing || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationships || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker || elasticsearch_has_missing || warnMissingCompiledFiles || warnDbRowFormat %] >+ [% IF weasyprint_missing || warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || warnPrefPatronSelfRegistrationDefaultCategory || invalid_yesno.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || warnI18nMissing || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationships || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker || elasticsearch_has_missing || warnMissingCompiledFiles || warnDbRowFormat || warnPassChangeNoticeMissing %] > [% IF ( warnDbRowFormat ) %] > <h2>Database row format incorrect</h2> > <p>Database tables with a row format other than 'DYNAMIC': [% warnDbRowFormat | html %]</p> >@@ -473,7 +473,7 @@ > Contact your system administrator. > [% END # /IF warnConnectBroker %] > >- [% IF weasyprint_missing || warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || warnPrefPatronSelfRegistrationDefaultCategory || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || warnXSLT || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnFastCataloging %] >+ [% IF weasyprint_missing || warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || warnPrefPatronSelfRegistrationDefaultCategory || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || warnXSLT || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnFastCataloging || warnPassChangeNoticeMissing %] > <h2>Warnings regarding the system configuration</h2> > <table> > <caption>Preferences and parameters</caption> >@@ -592,6 +592,15 @@ > <td> The PO directory has not been found. See <a href="https://wiki.koha-community.org/wiki/Translation_files">the dedicated wiki page</a> for more information. </td> > </tr> > [% END %] >+ [% IF warnPassChangeNoticeMissing %] >+ <tr> >+ <th scope="row"><strong>Warning</strong> </th> >+ <td >+ >System preference 'NotifyPasswordChange' is enabled, but the PASSWORD_CHANGE notice template is missing. Password changes will fail. Please create the PASSWORD_CHANGE notice template in >+ <a href="/cgi-bin/koha/tools/letter.pl">Tools > Notices and slips</a>.</td >+ > >+ </tr> >+ [% END %] > [% IF warnILLConfiguration %] > [% IF no_ill_backends %] > <tr> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40608
:
185166
|
185167
|
185179
|
185238
|
185239
|
185240
|
185241
|
185257
|
185258
| 185259 |
185260
|
185261