Bugzilla – Attachment 185261 Details for
Bug 40608
Password not changed if PASSWORD_CHANGE letter absent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40608: (QA follow-up) Delete notice in test, adjust about.tt
Bug-40608-QA-follow-up-Delete-notice-in-test-adjus.patch (text/plain), 2.53 KB, created by
Marcel de Rooy
on 2025-08-08 07:01:47 UTC
(
hide
)
Description:
Bug 40608: (QA follow-up) Delete notice in test, adjust about.tt
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-08-08 07:01:47 UTC
Size:
2.53 KB
patch
obsolete
>From bd8c74cc1ff1189c6c708b85ee5d8747a9d30742 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 8 Aug 2025 06:44:43 +0000 >Subject: [PATCH] Bug 40608: (QA follow-up) Delete notice in test, adjust > about.tt >Content-Type: text/plain; charset=utf-8 > >[1] This prevents a warn 'Violation of unique constraint in Letter' > from TestBuilder if the notice already exists. >[2] The about warn should no longer say that password changes will > fail but only warn about a missing notification. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 4 ++-- > t/db_dependent/Koha/Patron.t | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 1fd0a5cc61..b064224947 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -596,8 +596,8 @@ > <tr> > <th scope="row"><strong>Warning</strong> </th> > <td >- >System preference 'NotifyPasswordChange' is enabled, but the PASSWORD_CHANGE notice template is missing. Password changes will fail. Please create the PASSWORD_CHANGE notice template in >- <a href="/cgi-bin/koha/tools/letter.pl">Tools > Notices and slips</a>.</td >+ >System preference 'NotifyPasswordChange' is enabled, but the PASSWORD_CHANGE notice template is missing. Patrons will not be notified about password changes. Please create the PASSWORD_CHANGE notice template >+ in <a href="/cgi-bin/koha/tools/letter.pl">Tools > Notices and slips</a>.</td > > > </tr> > [% END %] >diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t >index d2d8182c81..b9c1eedc66 100755 >--- a/t/db_dependent/Koha/Patron.t >+++ b/t/db_dependent/Koha/Patron.t >@@ -1546,6 +1546,7 @@ subtest 'password expiration tests' => sub { > my $date = dt_from_string(); > my $category = > $builder->build_object( { class => 'Koha::Patron::Categories', value => { password_expiry_days => 10 } } ); >+ Koha::Notice::Templates->search( { code => 'PASSWORD_CHANGE', module => 'members' } )->delete; > my $patron = $builder->build_object( > { > class => 'Koha::Patrons', >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40608
:
185166
|
185167
|
185179
|
185238
|
185239
|
185240
|
185241
|
185257
|
185258
|
185259
|
185260
| 185261