Bugzilla – Attachment 185354 Details for
Bug 40105
Patrons cannot add notes when creating an ILL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40105: Patrons cannot add notes when creating an ILL
Bug-40105-Patrons-cannot-add-notes-when-creating-a.patch (text/plain), 3.74 KB, created by
Eric Phetteplace
on 2025-08-12 19:40:04 UTC
(
hide
)
Description:
Bug 40105: Patrons cannot add notes when creating an ILL
Filename:
MIME Type:
Creator:
Eric Phetteplace
Created:
2025-08-12 19:40:04 UTC
Size:
3.74 KB
patch
obsolete
>From bd14a30affbcbffac5f7bc6469a8f84051be48f2 Mon Sep 17 00:00:00 2001 >From: phette23 <phette23@gmail.com> >Date: Tue, 22 Jul 2025 15:45:00 -0700 >Subject: [PATCH] Bug 40105: Patrons cannot add notes when creating an ILL > >Testing plan: >- Enable the ILLModule system preference >- Sign into the OPAC and make an ILL request at /cgi-bin/koha/opac-illrequests.pl >- Note there's no option to specify notes >- Apply the patch and restart services >- Make another ILL request >- Use the new notes field >- View the request and note that the notes value was saved > >Sponsored-By: California College of the Arts >--- > Koha/ILL/Backend/Standard.pm | 1 + > .../bootstrap/en/includes/ill/backends/Standard/create.inc | 1 + > .../en/includes/ill/backends/Standard/shared/notes.inc | 5 +++++ > t/db_dependent/api/v1/ill_requests.t | 6 +++++- > 4 files changed, 12 insertions(+), 1 deletion(-) > create mode 100644 koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/notes.inc > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index 444c0074d9..b93e300db5 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -1001,6 +1001,7 @@ sub add_request { > $request->branchcode( $params->{other}->{branchcode} ); > $request->status( $unauthenticated_request ? 'UNAUTH' : 'NEW' ); > $request->backend( $params->{other}->{backend} ); >+ $request->notesopac( $params->{other}->{notesopac} ) if exists $params->{other}->{notesopac}; > $request->placed( dt_from_string() ); > $request->updated( dt_from_string() ); > $request->batch_id( >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc >index 4ef7691762..b5cd561e93 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc >@@ -103,6 +103,7 @@ > [% IF type %] > [% INCLUDE "ill/backends/Standard/shared/forms/${type}.inc" %] > [% END %] >+ [% INCLUDE "ill/backends/Standard/shared/notes.inc" %] > [% INCLUDE "ill/backends/Standard/shared/custom_fields.inc" %] > [% IF whole.value.other.type && unauthenticated_ill && !logged_in_user %] > <fieldset class="rows" id="illrequest_captcha"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/notes.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/notes.inc >new file mode 100644 >index 0000000000..5ec10d4579 >--- /dev/null >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/notes.inc >@@ -0,0 +1,5 @@ >+<fieldset class="rows" id="ill-standard-notes"> >+ <legend>Notes</legend> >+ <label class="sr-only" for="notesopac">Notes:</label> >+ <textarea name="notesopac" id="notesopac" class="form-control input-fluid">[% whole.value.other.notesopac | html %]</textarea> >+</fieldset> >diff --git a/t/db_dependent/api/v1/ill_requests.t b/t/db_dependent/api/v1/ill_requests.t >index d44c6ccad7..25bc13c12e 100755 >--- a/t/db_dependent/api/v1/ill_requests.t >+++ b/t/db_dependent/api/v1/ill_requests.t >@@ -416,7 +416,7 @@ subtest 'patron_list() tests' => sub { > > subtest 'add() tests' => sub { > >- plan tests => 2; >+ plan tests => 3; > > $schema->storage->txn_begin; > >@@ -525,5 +525,9 @@ subtest 'add() tests' => sub { > ## Authorized user test > $t->post_ok( "//$userid:$password@/api/v1/ill/requests" => json => $body )->status_is(201); > >+ # Confirm there is a notesopac value >+ my $req = Koha::ILL::Requests->search()->next; >+ ok( $req->notesopac, "notesopac value exists" ) if $req; >+ > $schema->storage->txn_rollback; > }; >-- >2.50.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40105
:
184523
| 185354