Bugzilla – Attachment 185445 Details for
Bug 34631
Independentbranches - Non-superuser should not be able to write Additional contents for other branches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34631: (follow-up) Non-superlibrarians should not have the right to select the library
Bug-34631-follow-up-Non-superlibrarians-should-not.patch (text/plain), 2.02 KB, created by
Hammat wele
on 2025-08-15 12:49:36 UTC
(
hide
)
Description:
Bug 34631: (follow-up) Non-superlibrarians should not have the right to select the library
Filename:
MIME Type:
Creator:
Hammat wele
Created:
2025-08-15 12:49:36 UTC
Size:
2.02 KB
patch
obsolete
>From ff12174409d8cd74a2cb2f2f0fc49bd75674166d Mon Sep 17 00:00:00 2001 >From: Hammat Wele <hammat.wele@inlibro.com> >Date: Thu, 24 Jul 2025 19:40:00 +0000 >Subject: [PATCH] Bug 34631: (follow-up) Non-superlibrarians should not have > the right to select the library > >--- > .../prog/en/modules/admin/preferences/admin.pref | 2 +- > tools/additional-contents.pl | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >index f618eb468a9..5310ecc3c99 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >@@ -149,7 +149,7 @@ Administration: > 1: "Yes" > 0: "No" > - >- - "Prevent staff (but not superlibrarians) from editing Additional contents in other libraries: " >+ - "Prevent staff (but not superlibrarians) from editing additional contents for other libraries: " > - pref: IndependentBranchesAdditionalcontents > default: 0 > choices: >diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl >index 90bdbc194bf..a95725b7206 100755 >--- a/tools/additional-contents.pl >+++ b/tools/additional-contents.pl >@@ -71,10 +71,10 @@ my $my_branch_as_staff = > if ( $op eq 'add_form' ) { > > my $additional_content = Koha::AdditionalContents->find($id); >- $additional_content = >- undef $my_branch_as_staff >+ $additional_content = undef >+ if ( $my_branch_as_staff > && $additional_content >- && C4::Context->userenv()->{'branch'} ne $additional_content->branchcode; >+ && C4::Context->userenv()->{'branch'} ne $additional_content->branchcode ); > my $translated_contents; > if ($additional_content) { > $translated_contents = { map { $_->lang => $_ } $additional_content->translated_contents->as_list }; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34631
:
154889
|
154890
|
162787
|
162788
|
162856
|
162929
|
162972
|
162995
|
172231
|
175973
|
175974
|
175975
|
175976
|
179859
|
179860
|
180602
|
180603
|
180604
|
184604
|
185420
|
185421
|
185422
|
185423
|
185424
|
185442
|
185443
|
185444
| 185445 |
185446