Bugzilla – Attachment 185447 Details for
Bug 40658
When sorting by local-number we should use the sort field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40658: Atomic update to ensure local-number is sortable
Bug-40658-Atomic-update-to-ensure-local-number-is-.patch (text/plain), 2.47 KB, created by
Nick Clemens (kidclamp)
on 2025-08-15 13:17:57 UTC
(
hide
)
Description:
Bug 40658: Atomic update to ensure local-number is sortable
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-08-15 13:17:57 UTC
Size:
2.47 KB
patch
obsolete
>From eee25123851e8230ab620f569ab0ffe0027f1cc4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 15 Aug 2025 13:16:31 +0000 >Subject: [PATCH] Bug 40658: Atomic update to ensure local-number is sortable > >I don't know if this is appropriate for master as it requires Koha objects, >but this is helpful for upgrading sites to avoid any problems from old mappings >for local-number >--- > .../data/mysql/atomicupdate/bug_40658.pl | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100755 installer/data/mysql/atomicupdate/bug_40658.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_40658.pl b/installer/data/mysql/atomicupdate/bug_40658.pl >new file mode 100755 >index 00000000000..753481805de >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_40658.pl >@@ -0,0 +1,41 @@ >+use Modern::Perl; >+use Koha::Installer::Output qw(say_warning say_success say_info); >+use Koha::SearchEngine::Elasticsearch::Indexer; >+ >+return { >+ bug_number => "40658", >+ description => "Ensure local-number is sortable", >+ up => sub { >+ my ($args) = @_; >+ my ( $dbh, $out ) = @$args{qw(dbh out)}; >+ >+ # Do you stuffs here >+ my ( $local_number_map_id, $local_number_sortable ) = $dbh->selectrow_array( >+ q| >+ SELECT search_marc_map_id,sort FROM search_field >+ JOIN search_marc_to_field ON search_field.id = search_marc_to_field.search_field_id >+ JOIN search_marc_map ON search_marc_to_field.search_marc_map_id = search_marc_map.id >+ WHERE search_field.name='local-number' AND index_name = 'biblios' AND marc_type='marc21'; >+ | >+ ); >+ >+ if ( defined $local_number_map_id && $local_number_sortable == 0 ) { >+ $dbh->do( >+ q{ >+ UPDATE search_marc_to_field >+ SET sort = 1 >+ WHERE search_marc_map_id = ? >+ }, undef, $local_number_map_id >+ ); >+ >+ my $index_name = $Koha::SearchEngine::Elasticsearch::BIBLIOS_INDEX; >+ my $indexer = Koha::SearchEngine::Elasticsearch::Indexer->new( { index => $index_name } ); >+ $indexer->update_mappings(); >+ say $out "Updated ES mappings to make local-number sortable"; >+ } elsif ( !defined $local_number_map_id ) { >+ say_warning( $out, "No mapping defined for local-number" ); >+ } else { >+ say_info( $out, "local-number already sortable" ); >+ } >+ }, >+}; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40658
:
185441
| 185447