Bugzilla – Attachment 185471 Details for
Bug 39883
NEW_SUGGESTION email notices end up in the patrons notice tab (members/notices.pl) when they should not
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39883: (follow-up) Retrieve messages by letter_code
Bug-39883-follow-up-Retrieve-messages-by-lettercod.patch (text/plain), 2.61 KB, created by
Lucas Gass (lukeg)
on 2025-08-15 15:46:43 UTC
(
hide
)
Description:
Bug 39883: (follow-up) Retrieve messages by letter_code
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-08-15 15:46:43 UTC
Size:
2.61 KB
patch
obsolete
>From 5054aabeb0ffdb8a8184d49312b57c3c26c68422 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 15 Aug 2025 15:45:59 +0000 >Subject: [PATCH] Bug 39883: (follow-up) Retrieve messages by letter_code > >--- > t/db_dependent/Suggestions.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t >index d7d289f7f06..75cc4db883a 100755 >--- a/t/db_dependent/Suggestions.t >+++ b/t/db_dependent/Suggestions.t >@@ -612,7 +612,7 @@ subtest 'EmailPurchaseSuggestions' => sub { > # EmailPurchaseSuggestions set to disabled > t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0" ); > Koha::Suggestion->new($my_suggestion)->store; >- my $newsuggestions_messages = C4::Letters::GetQueuedMessages( { borrowernumber => $borrowernumber } ); >+ my $newsuggestions_messages = C4::Letters::GetQueuedMessages( { letter_code => 'NEW_SUGGESTION' } ); > is( > @$newsuggestions_messages, 0, > 'New suggestion does not send an email when EmailPurchaseSuggestions disabled' >@@ -634,7 +634,7 @@ subtest 'EmailPurchaseSuggestions' => sub { > Koha::Libraries->find('CPL')->update( { branchreplyto => 'branchemail@b.c' } ); > Koha::Suggestion->new($my_suggestion)->store; > >- $newsuggestions_messages = C4::Letters::GetQueuedMessages( { borrowernumber => $borrowernumber } ); >+ $newsuggestions_messages = C4::Letters::GetQueuedMessages( { letter_code => 'NEW_SUGGESTION' } ); > isnt( @$newsuggestions_messages, 0, 'New suggestions sends an email wne EmailPurchaseSuggestions enabled' ); > my $message1 = > C4::Letters::GetMessage( $newsuggestions_messages->[0]->{message_id} ); >@@ -673,7 +673,7 @@ subtest 'EmailPurchaseSuggestions' => sub { > t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' ); > Koha::Suggestion->new($my_suggestion)->store; > >- $newsuggestions_messages = C4::Letters::GetQueuedMessages( { borrowernumber => $borrowernumber } ); >+ $newsuggestions_messages = C4::Letters::GetQueuedMessages( { letter_code => 'NEW_SUGGESTION' } ); > my $message5 = > C4::Letters::GetMessage( $newsuggestions_messages->[4]->{message_id} ); > is( >@@ -705,7 +705,7 @@ subtest 'EmailPurchaseSuggestions' => sub { > ); > Koha::Suggestion->new($my_suggestion)->store; > >- $newsuggestions_messages = C4::Letters::GetQueuedMessages( { borrowernumber => $borrowernumber } ); >+ $newsuggestions_messages = C4::Letters::GetQueuedMessages( { letter_code => 'NEW_SUGGESTION' } ); > my $message7 = > C4::Letters::GetMessage( $newsuggestions_messages->[6]->{message_id} ); > is( >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39883
:
182315
|
182391
|
185133
|
185467
| 185471