Bugzilla – Attachment 185514 Details for
Bug 40664
Serial subscription input missing "Required" labels
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40664: Serial subscription input missing "Required" labels
Bug-40664-Serial-subscription-input-missing-Requir.patch (text/plain), 2.34 KB, created by
Caroline Cyr La Rose
on 2025-08-18 13:42:08 UTC
(
hide
)
Description:
Bug 40664: Serial subscription input missing "Required" labels
Filename:
MIME Type:
Creator:
Caroline Cyr La Rose
Created:
2025-08-18 13:42:08 UTC
Size:
2.34 KB
patch
obsolete
>From c5e30dad8a4a69d720401759a96c5f01f79b744f Mon Sep 17 00:00:00 2001 >From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Date: Mon, 18 Aug 2025 09:39:26 -0400 >Subject: [PATCH] Bug 40664: Serial subscription input missing "Required" > labels > >This patch adds missing "Required" labels next to two mandatory fields >in the second page of the new serial subscription form. > >To test: >1. Go to Serials >2. Click 'New subscription' >3. Enter a biblionumber in the 'Record' field (e.g. 230) >4. Click 'Next' >5. (Click 'OK' to confirm that you are not adding a vendor) >--> On the page 'Add a new subscription (2/2)' the fields 'Frequency' and 'Subscription start date' are red to indicate that they are mandatory, but there is no 'Required' note next to them. >6. Apply patch and refresh the page >--> It should say 'Required' next to all the mandatory fields (in red) >--- > .../intranet-tmpl/prog/en/modules/serials/subscription-add.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >index 1e62a1108e4..d294648b5e1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >@@ -334,6 +334,7 @@ > <option value="[% frequency.id | html %]" [% IF frequency.selected %]selected="selected"[% END %]> [% frequency.label | html %] </option> > [% END %] > </select> >+ <span class="required">Required</span> > </li> > <li> > <label for="subtype">Subscription length:</label> >@@ -369,6 +370,7 @@ > <li> > <label for="from" class="required"> Subscription start date:</label> > <input type="text" size="10" id="from" name="startdate" value="[% startdate | html %]" class="flatpickr required" data-date_to="to" required="required" /> >+ <span class="required">Required</span> > </li> > <li> > <label for="to">Subscription end date:</label> >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40664
: 185514