Bugzilla – Attachment 185584 Details for
Bug 11999
Add two checks in CanBookBeReserved and CanItemBeReserved
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved
Bug-11999-Add-maxreserves-check-in-CanBookBeReserv.patch (text/plain), 2.59 KB, created by
Arthur Suzuki
on 2025-08-20 13:36:04 UTC
(
hide
)
Description:
Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved
Filename:
MIME Type:
Creator:
Arthur Suzuki
Created:
2025-08-20 13:36:04 UTC
Size:
2.59 KB
patch
obsolete
>From 521ff06207062658d2799269b651acf579e44e08 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Wed, 26 Mar 2014 10:51:59 +0100 >Subject: [PATCH] Bug 11999: Add maxreserves check in CanBookBeReserved and > CanItemBeReserved > >- Check if borrower has reached the maximum number of holds allowed > (syspref maxreserves) > >The goal of this patch is to do these checks also when using ILS-DI >services HoldTitle and HoldItem > >Test plan: >---------- >Before patch: >1/ Set syspref maxreserves to 1 >2/ Place some holds through ILS-DI and note that you can place more than > 1 hold for a borrower > >Apply the patch >3/ Place some holds through ILS-DI, you shouldn't be able to place more > than 1 hold for a borrower >4/ Try to place holds on staff interface and OPAC. The behaviour must be > identical than before the patch. > >Maxreserves and alreadyreserved works on ILSDI >Maxreserves works also on staff and opac >Already reserves works also on staff and opac >tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) > >Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> >Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> >--- > C4/Reserves.pm | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 87a645a3e3b..90086386fd9 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -420,6 +420,14 @@ sub CanBookBeReserved { > > my $canReserve = { status => '' }; > my $patron = Koha::Patrons->find($borrowernumber); >+ my $holds = $patron->holds; >+ >+ # Check if borrower has reached the maximum number of holds allowed >+ my $maxreserves = C4::Context->preference('maxreserves'); >+ if ( $maxreserves && $holds->count >= $maxreserves ) { >+ return { status => 'tooManyReserves', limit => $maxreserves }; >+ } >+ > while ( my $item = $items->next ) { > $canReserve = CanItemBeReserved( $patron, $item, $pickup_branchcode, $params ); > return { status => 'OK' } if $canReserve->{status} eq 'OK'; >@@ -516,6 +524,12 @@ sub CanItemBeReserved { > return _cache { status => 'recall' } > if $patron->recalls->filter_by_current->search( { item_id => $item->itemnumber } )->count; > >+ # Check if borrower has reached the maximum number of holds allowed >+ my $maxreserves = C4::Context->preference('maxreserves'); >+ if ( $maxreserves && $patron->holds->count >= $maxreserves ) { >+ return { status => 'tooManyReserves', limit => $maxreserves }; >+ } >+ > my $controlbranch = C4::Context->preference('ReservesControlBranch'); > > my $reserves_control_branch; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11999
:
26589
|
28986
|
31524
|
35697
|
36358
|
36404
|
36630
|
38397
|
41951
|
41952
|
44631
|
44632
|
46262
|
46263
|
50224
|
50225
|
58741
|
58742
|
58743
|
63593
|
63594
|
63595
|
66267
|
66268
|
66269
|
66270
|
88300
|
88301
|
88302
|
88303
|
90142
|
90143
|
90144
|
90146
|
90147
|
91046
|
91402
|
91403
|
91479
|
91481
|
91494
|
91580
|
91581
|
91582
|
91590
|
91591
|
91592
|
91593
|
99927
|
99928
|
106481
|
106494
|
111687
|
111688
|
111689
|
112871
|
112872
|
112873
|
112874
|
120776
|
120777
|
120778
|
120779
|
120780
|
121531
|
121612
| 185584 |
185585
|
185586