Bugzilla – Attachment 185600 Details for
Bug 40654
Sorting holds table can cause priority issues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40654: Adjust display to show current priority
Bug-40654-Adjust-display-to-show-current-priority.patch (text/plain), 8.45 KB, created by
Lucas Gass (lukeg)
on 2025-08-20 17:14:59 UTC
(
hide
)
Description:
Bug 40654: Adjust display to show current priority
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-08-20 17:14:59 UTC
Size:
8.45 KB
patch
obsolete
>From 83c7d4ac95fd0ff5eea7be507f893fc80c52c9da Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 20 Aug 2025 16:34:14 +0000 >Subject: [PATCH] Bug 40654: Adjust display to show current priority > >--- > .../prog/en/includes/holds_table.inc | 78 ++++++++++--------- > .../prog/en/modules/reserve/request.tt | 8 ++ > 2 files changed, 50 insertions(+), 36 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 70ff63bf366..7546ab5cec6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -45,48 +45,54 @@ > [%- this_priority = loop.count() - found_holds -%] > [%- END -%] > [% SET tr_class = hold.suspend ? 'suspend' : '' %] >- <tr class="[% tr_class | html %]"> >+ <tr class="[% tr_class | html %]" data-order="[% priority | html %]"> > <td><input type="checkbox" class="select_hold" data-id="[% hold.reserve_id | html %]" /></td> >- <td> >- <input type="hidden" name="reserve_id" value="[% hold.reserve_id | html %]" /> >- <input type="hidden" name="borrowernumber" value="[% hold.borrowernumber | html %]" /> >- <input type="hidden" name="biblionumber" value="[% hold.biblionumber | html %]" /> >- [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] >- [% IF Koha.Preference('HoldsSplitQueue') == "nothing" && !hold.found %] >- <select name="rank-request" class="rank-request" data-hold-id="[% hold.reserve_id | html %]"> >- [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] >- [% FOREACH priority IN all_priorities %] >- [% IF priority == this_priority %] >- <option value="[% priority | html %]" selected="selected">[% priority | html %]</option> >- [% ELSIF priority > 0 %] >- <option value="[% priority | html %]">[% priority | html %]</option> >+ <td style="min-width:185px;" data-order="[% priority | html %]"> >+ <div> >+ <input type="hidden" name="reserve_id" value="[% hold.reserve_id | html %]" /> >+ <input type="hidden" name="borrowernumber" value="[% hold.borrowernumber | html %]" /> >+ <input type="hidden" name="biblionumber" value="[% hold.biblionumber | html %]" /> >+ [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] >+ [% IF Koha.Preference('HoldsSplitQueue') == "nothing" && !hold.found %] >+ <label for="rank-request_[% hold.reserve_id | html %]">Change priority to:</label> >+ <select name="rank-request" id="rank-request_[% hold.reserve_id | html %]" class="rank-request" data-hold-id="[% hold.reserve_id | html %]"> >+ [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] >+ [% FOREACH priority IN all_priorities %] >+ [% IF priority == this_priority %] >+ <option value="[% priority | html %]" selected="selected">[% priority | html %]</option> >+ [% ELSIF priority > 0 %] >+ <option value="[% priority | html %]">[% priority | html %]</option> >+ [% END %] > [% END %] >+ [% ELSE %] >+ <option value="[% hold.priority | html %]" selected="selected">[% this_priority | html %]</option> > [% END %] >- [% ELSE %] >- <option value="[% hold.priority | html %]" selected="selected">[% this_priority | html %]</option> >- [% END %] >- <option value="del">del</option> >- </select> >- [% ELSE %] >- <input type="hidden" name="rank-request" class="rank-request" value="[% hold.priority | html %]" data-hold-id="[% hold.reserve_id | html %]" /> >- <select name="rank-request" class="rank-request" disabled="disabled" data-hold-id="[% hold.reserve_id | html %]"> >- [% IF ( hold.found ) %] >- [% IF ( hold.intransit ) %] >- <option value="T" selected="selected">In transit</option> >- [% ELSIF (hold.inprocessing) %] >- <option value="P" selected="selected">In processing</option> >+ <option value="del">del</option> >+ </select> >+ [% ELSE %] >+ <input type="hidden" name="rank-request" class="rank-request" value="[% hold.priority | html %]" data-hold-id="[% hold.reserve_id | html %]" /> >+ <select name="rank-request" class="rank-request" disabled="disabled" data-hold-id="[% hold.reserve_id | html %]"> >+ [% IF ( hold.found ) %] >+ [% IF ( hold.intransit ) %] >+ <option value="T" selected="selected">In transit</option> >+ [% ELSIF (hold.inprocessing) %] >+ <option value="P" selected="selected">In processing</option> >+ [% ELSE %] >+ <option value="W" selected="selected">Waiting</option> >+ [% END %] > [% ELSE %] >- <option value="W" selected="selected">Waiting</option> >+ <option value="[% hold.priority | html %]" selected="selected">[% this_priority | html %]</option> > [% END %] >- [% ELSE %] >- <option value="[% hold.priority | html %]" selected="selected">[% this_priority | html %]</option> >- [% END %] >- </select> >+ </select> >+ [% END %] >+ [% ELSE %] >+ <input type="hidden" name="rank-request" class="rank-request" value="[% hold.priority | html %]" data-hold-id="[% hold.reserve_id | html %]" /> > [% END %] >- [% ELSE %] >- <input type="hidden" name="rank-request" class="rank-request" value="[% hold.priority | html %]" data-hold-id="[% hold.reserve_id | html %]" /> >- [% hold.priority | html %] >- [% END %] >+ <div> >+ <label for="current_priority_[% hold.reserve_id | html %]">Current priority: </label> >+ <span id="current_priority_[% hold.reserve_id | html %]" class="current_priority badge text-bg-info">[% hold.priority | html %]</span> >+ </div> >+ </div> > </td> > [%- IF ( CAN_user_reserveforothers_modify_holds_priority ) -%] > [%- UNLESS hold.found -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index e50c188a02a..2b532fba385 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -105,6 +105,14 @@ > :disabled { > opacity: 0.5; > } >+ .current_priority { >+ width: 50px; >+ text-align: left; >+ margin-top: 5px; >+ } >+ .rank-request { >+ width: 50px; >+ } > </style> > [% END %] > </head> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40654
:
185419
|
185477
|
185589
|
185590
|
185597
|
185600
|
185605
|
185606