Bugzilla – Attachment 185623 Details for
Bug 40395
Allow selecting multiple holds in patron detail page to perform actions on
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40395: (QA follow-up): Remove unused form
Bug-40395-QA-follow-up-Remove-unused-form.patch (text/plain), 4.19 KB, created by
Pedro Amorim
on 2025-08-21 10:57:25 UTC
(
hide
)
Description:
Bug 40395: (QA follow-up): Remove unused form
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-08-21 10:57:25 UTC
Size:
4.19 KB
patch
obsolete
>From a77e5f815b89cd5dd4043df7262c25b47df84f5d Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 21 Aug 2025 10:54:28 +0000 >Subject: [PATCH] Bug 40395: (QA follow-up): Remove unused form > >This form is no longer used. We're now using a single cancellation hold modal and them form resides there, not here on this table >To test on the UI: Apply this patch and ensure cancelling holds works as before, from both pages (tested using borrowernumber 19: ><staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 ><staff_url>/cgi-bin/koha/reserve/request.pl?biblionumber=76&biblionumber=437&biblionumber=77 > >Fixed the failing test: >prove xt/find-missing-op-in-forms.t >--- > .../prog/en/includes/patron-detail-tabs.inc | 50 +++++++++---------- > 1 file changed, 23 insertions(+), 27 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >index b59888eca45..654a41a3dee 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc >@@ -143,33 +143,29 @@ > [% IF ( CAN_user_circulate_circulate_remaining_permissions ) %] > [% WRAPPER tab_panel tabname="holds" %] > [% IF ( holds_count ) %] >- <form action="/cgi-bin/koha/reserve/modrequest.pl" method="post"> >- [% INCLUDE 'csrf-token.inc' %] >- <input type="hidden" name="from" value="circ" /> >- <table id="holds-table" class="holds_table" style="width: 100% !Important;"> >- <thead> >- <tr> >- <th id="checkbox" data-colname="checkbox"><input type="checkbox" class="select_hold_all" /></th> >- <th>Hold date</th> >- <th class="anti-the">Title</th> >- <th>Call number</th> >- <th>Item type</th> >- <th>Barcode</th> >- <th>Pickup at</th> >- <th>Expiration</th> >- <th>Priority</th> >- <th>Notes</th> >- <th>Delete?</th> >- <th>Suspend?</th> >- <th>Status</th> >- </tr> >- </thead> >- </table> >- >- <fieldset class="action"> >- <button class="btn btn-primary cancel_selected_holds" data-bulk="true"></button> >- </fieldset> >- </form> >+ <table id="holds-table" class="holds_table" style="width: 100% !Important;"> >+ <thead> >+ <tr> >+ <th id="checkbox" data-colname="checkbox"><input type="checkbox" class="select_hold_all" /></th> >+ <th>Hold date</th> >+ <th class="anti-the">Title</th> >+ <th>Call number</th> >+ <th>Item type</th> >+ <th>Barcode</th> >+ <th>Pickup at</th> >+ <th>Expiration</th> >+ <th>Priority</th> >+ <th>Notes</th> >+ <th>Delete?</th> >+ <th>Suspend?</th> >+ <th>Status</th> >+ </tr> >+ </thead> >+ </table> >+ >+ <fieldset class="action"> >+ <button class="btn btn-primary cancel_selected_holds" data-bulk="true"></button> >+ </fieldset> > > [% PROCESS 'cancel-hold-modal' form_action = '/cgi-bin/koha/reserve/modrequest.pl' from_param = patronpage %] > [% PROCESS 'suspend-hold-modal' %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40395
:
184109
|
184110
|
184111
|
184112
|
184113
|
184114
|
184115
|
184116
|
184134
|
184135
|
184136
|
184137
|
184138
|
184139
|
184140
|
184141
|
184398
|
184399
|
184400
|
184401
|
184402
|
184403
|
184404
|
184405
|
184434
|
184435
|
184437
|
184470
|
184471
|
184472
|
184473
|
184474
|
184475
|
184476
|
184477
|
184478
|
184479
|
184765
|
184766
|
184767
|
184768
|
184769
|
184770
|
184771
|
184772
|
184773
|
184774
|
185508
| 185623