Bugzilla – Attachment 185673 Details for
Bug 20644
Per itemtype setting for CheckPrevCheckout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20644: (follow-up) Fix swagger description + put "inherit" by default
Bug-20644-follow-up-Fix-swagger-description--put-i.patch (text/plain), 2.29 KB, created by
Shi Yao Wang
on 2025-08-21 21:40:58 UTC
(
hide
)
Description:
Bug 20644: (follow-up) Fix swagger description + put "inherit" by default
Filename:
MIME Type:
Creator:
Shi Yao Wang
Created:
2025-08-21 21:40:58 UTC
Size:
2.29 KB
patch
obsolete
>From 66f0c7da7eacd44b325c398aa55dcedeb6e1c09f Mon Sep 17 00:00:00 2001 >From: Shi Yao Wang <shi-yao.wang@inlibro.com> >Date: Thu, 21 Aug 2025 17:38:32 -0400 >Subject: [PATCH] Bug 20644: (follow-up) Fix swagger description + put > "inherit" by default > >--- > admin/itemtypes.pl | 7 ++----- > api/v1/swagger/definitions/item_type.yaml | 2 +- > 2 files changed, 3 insertions(+), 6 deletions(-) > >diff --git a/admin/itemtypes.pl b/admin/itemtypes.pl >index cfccde48da9..e52bd11ee53 100755 >--- a/admin/itemtypes.pl >+++ b/admin/itemtypes.pl >@@ -99,7 +99,7 @@ if ( $op eq 'add_form' ) { > my $rentalcharge_hourly_calendar = $input->param('rentalcharge_hourly_calendar') // 0; > my $automatic_checkin = $input->param('automatic_checkin') // 0; > my $bookable = $input->param('bookable') // 0; >- my $checkprevcheckout = $input->param('checkprevcheckout'); >+ my $checkprevcheckout = $input->param('checkprevcheckout') // 'inherit'; > > if ( $itemtype and $is_a_modif ) { # it's a modification > $itemtype->description($description); >@@ -121,10 +121,7 @@ if ( $op eq 'add_form' ) { > $itemtype->rentalcharge_hourly_calendar($rentalcharge_hourly_calendar); > $itemtype->automatic_checkin($automatic_checkin); > $itemtype->bookable($bookable); >- >- if ( defined $checkprevcheckout ) { >- $itemtype->checkprevcheckout($checkprevcheckout); >- } >+ $itemtype->checkprevcheckout($checkprevcheckout); > > eval { > $itemtype->store; >diff --git a/api/v1/swagger/definitions/item_type.yaml b/api/v1/swagger/definitions/item_type.yaml >index 354aa68db7c..44801329a99 100644 >--- a/api/v1/swagger/definitions/item_type.yaml >+++ b/api/v1/swagger/definitions/item_type.yaml >@@ -99,7 +99,7 @@ properties: > - yes > - no > - inherit >- description: Produce a warning for this item type if this item has previously been checked out to this patron if ''yes'', not if ''no'', defer to syspref setting if ''inherit''.' >+ description: Produce a warning for this item type if this item has previously been checked out to this patron if ''yes'', not if ''no'', defer to patron setting if ''inherit'' > > additionalProperties: false > required: >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20644
:
156974
|
156977
|
163627
|
165585
|
165586
|
165661
|
165662
|
170619
|
170620
|
170621
|
170622
|
176538
|
176539
|
178093
|
178094
|
179812
|
179813
|
179814
|
179815
|
180375
|
181680
|
181681
|
182469
|
182470
|
182476
|
182477
|
182787
|
182788
|
183403
|
183404
|
183405
|
183406
|
183407
|
183408
|
185448
|
185449
|
185450
|
185451
|
185478
|
185479
|
185480
|
185481
|
185557
|
185558
|
185559
|
185560
|
185665
|
185666
|
185669
|
185670
|
185671
|
185672
| 185673