Bugzilla – Attachment 185746 Details for
Bug 40602
Broken HTML showing in Alert 'subscriptions' tab
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40602: Broken HTML showing in Alert 'subscriptions' tab
Bug-40602-Broken-HTML-showing-in-Alert-subscriptio.patch (text/plain), 1.73 KB, created by
Owen Leonard
on 2025-08-25 16:38:18 UTC
(
hide
)
Description:
Bug 40602: Broken HTML showing in Alert 'subscriptions' tab
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-08-25 16:38:18 UTC
Size:
1.73 KB
patch
obsolete
>From 161d3c940c3422740afa58b8af3ec81944223d50 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 25 Aug 2025 16:13:02 +0000 >Subject: [PATCH] Bug 40602: Broken HTML showing in Alert 'subscriptions' tab > >This patch adds handling of the "no-html" flag to patron-title.inc. The >OPAC alert subscriptions page passes the "no-html" flag but the include >file wasn't written to include it. > >To test, apply the patch and log in to the OPAC as a user who has a >title (salutation). > >- Add a serial subscription and set a notification template >- Go to the OPAC and subscribe to the email notification for this > subscription >- Go to the patron account > Alert subscriptions tab >- Verify that the last column shows an "Unsubscribe from email alerts" > button. >- There should be no errant HTML. > >Sponsored-by: Athens County Public Libraries >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc >index 76efdbf8594..9a67aea33f2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/patron-title.inc >@@ -2,7 +2,11 @@ > [% patron.surname | html %][% IF patron.othernames %]([% patron.othernames | html %])[%- END -%] > [%- ELSE -%] > [%- IF patron.title -%] >- <span class="patron-title">[% patron.title | html %]</span> >+ [%- IF no_html -%] >+ [% patron.title | html %] >+ [%- ELSE -%] >+ <span class="patron-title"></span> >+ [%- END -%] > [%- END -%] > [% patron.preferred_name | html %] > [% patron.middle_name | html %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40602
:
185746
|
186169
|
186372
|
186433