Bugzilla – Attachment 185764 Details for
Bug 31698
Add ability to move a hold to a new bibliographic record/item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31698: Report errors and failures back to request.tt
Bug-31698-Report-errors-and-failures-back-to-reque.patch (text/plain), 4.79 KB, created by
Lucas Gass (lukeg)
on 2025-08-25 21:50:59 UTC
(
hide
)
Description:
Bug 31698: Report errors and failures back to request.tt
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-08-25 21:50:59 UTC
Size:
4.79 KB
patch
obsolete
>From 1415d5b0977f0426ba0008004a7d1363848072fe Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 25 Aug 2025 21:48:17 +0000 >Subject: [PATCH] Bug 31698: Report errors and failures back to request.tt > >--- > .../prog/en/modules/reserve/request.tt | 56 ++++++++++++++++++- > 1 file changed, 55 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 928d3eb3634..833b41d164c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -178,7 +178,59 @@ > [% END %] > </div> > [% END %] >- >+ [% IF ( hold_move_successes ) %] >+ <div class="alert alert-success"> >+ <p>Moved the following holds:</p> >+ <ul> >+ [% FOREACH hold IN hold_move_successes %] >+ <li> >+ <label>Hold ID: </label> >+ <span>[% hold.hold_id | html %]</span> >+ <span> - Moved from [%- INCLUDE 'biblio-title.inc' biblio=hold.original_biblio link = 1 -%] to [%- INCLUDE 'biblio-title.inc' biblio=hold.target_biblio link = 1 -%]</span> >+ </li> >+ [% END %] >+ </ul> >+ </div> >+ [% END %] >+ [% IF ( hold_move_failures ) %] >+ <div class="alert alert-warning"> >+ <strong>One or more holds were not moved due to following errors:</strong> >+ <ul> >+ [% FOREACH fail IN hold_move_failures %] >+ <li> >+ <label>Hold ID: </label> >+ <span>[% fail.hold_id | html %]</span> >+ [% SWITCH fail.error %] >+ [% CASE 'cannotReserveFromOtherBranches' %] >+ <span>Target item cannot be reserved from other branches</span> >+ [% CASE 'ageRestricted' %] >+ <span>The target record and/or items are age restricted</span> >+ [% CASE 'alreadypossession' %] >+ <span>Target item is already checked out to patron</span> >+ [% CASE 'noReservesAllowed' %] >+ <span>No holds are allowed on the target item(s)</span> >+ [% CASE 'tooManyReservesToday' %] >+ <span>Target item has too many holds placed on it today</span> >+ [% CASE 'tooManyReserves' %] >+ <span>Target item has too many holds placed on it</span> >+ [% CASE 'notReservable' %] >+ <span>Target item is not reservable</span> >+ [% CASE 'cannotReserveFromOtherBranches' %] >+ <span>Target item cannot be placed on reserve for this branch</span> >+ [% CASE 'branchNotInHoldGroup' %] >+ <span>Tagret item is not in the local hold group</span> >+ [% CASE 'notforloan' %] >+ <span>Target item is not for loan</span> >+ [% CASE 'damaged' %] >+ <span>Target item is damaged</span> >+ [% CASE %] >+ <span>Error: [% fail.error | html %]</span> >+ [% END %] >+ </li> >+ [% END %] >+ </ul> >+ </div> >+ [% END %] > [% IF ( failed_holds ) %] > <div class="alert alert-warning"> > <strong>One or more holds were not placed due to following errors:</strong> >@@ -1418,6 +1470,7 @@ > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="op" value="cud-move_hold_item" /> > <input type="hidden" name="original_biblionumber" value="[% biblio.biblionumber | html %]" /> >+ <input type="hidden" name="biblionumber" value="[% biblio.biblionumber | html %]" /> > <div id="itemResultMessage" class="mt-3"> </div> > <div id="move_hold_item_selection"> > <h3>Review holds to move</h3> >@@ -1464,6 +1517,7 @@ > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="op" value="cud-move_hold_biblio" /> > <input type="hidden" name="original_biblionumber" value="[% biblio.biblionumber | html %]" /> >+ <input type="hidden" name="biblionumber" value="[% biblio.biblionumber | html %]" /> > <div id="biblioResultMessage" class="mt-3"> </div> > <div id="move_hold_biblio_selection"> > <h3>Review holds to move</h3> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31698
:
179226
|
179235
|
179236
|
179279
|
179287
|
179290
|
179291
|
179292
|
179295
|
179704
|
179711
|
179713
|
181222
|
181223
|
181224
|
181225
|
181226
|
181228
|
181229
|
181230
|
181231
|
181232
|
181233
|
181234
|
181929
|
181930
|
181944
|
181945
|
181946
|
181947
|
181948
|
181951
|
181952
|
181953
|
181954
|
181955
|
181956
|
181957
|
181958
|
181959
|
181960
|
181961
|
181962
|
182639
|
182640
|
182641
|
184750
|
185050
|
185064
|
185065
|
185066
|
185067
|
185068
|
185069
|
185070
|
185121
|
185379
|
185380
|
185607
|
185608
|
185609
|
185610
|
185611
|
185612
|
185613
|
185614
|
185615
|
185616
|
185753
|
185754
|
185755
|
185756
|
185757
|
185758
|
185759
|
185760
|
185761
|
185762
|
185763
|
185764
|
185765
|
185766
|
185767
|
185768
|
185769
|
185770
|
185771
|
185772
|
185773
|
185774
|
185775
|
185776
|
185834