Bugzilla – Attachment 185803 Details for
Bug 40706
Improve the display of priority on reserve/request.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40706: Improve priority display on reserve/request.pl
Bug-40706-Improve-priority-display-on-reservereque.patch (text/plain), 4.46 KB, created by
Lucas Gass (lukeg)
on 2025-08-26 16:48:24 UTC
(
hide
)
Description:
Bug 40706: Improve priority display on reserve/request.pl
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-08-26 16:48:24 UTC
Size:
4.46 KB
patch
obsolete
>From c4df58fe17534534fd5f80d63243e85b8df7fffc Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 26 Aug 2025 16:44:22 +0000 >Subject: [PATCH] Bug 40706: Improve priority display on reserve/request.pl > >The main goal of this patch is to ensure that the "Change priority to:" and "Current priority:" numbers line up along the page, making it easy to read/parse the data in that column. > >To test: >1. APPLY PATCH >2. Make 1 hold on an item and go to reserve/request.pl >3. Observe the prioroty column, ensuring it looks good and the priority numbers line up nicely. >4. Make many holds, ensuring the columns look good and the priority numbers line up nicely. >--- > .../intranet-tmpl/prog/en/includes/holds_table.inc | 12 +++++------- > .../intranet-tmpl/prog/en/modules/reserve/request.tt | 7 +++++++ > 2 files changed, 12 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index fdbaabed25c..69a006920a7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -47,14 +47,14 @@ > [% SET tr_class = hold.suspend ? 'suspend' : '' %] > <tr class="[% tr_class | html %]"> > <td><input type="checkbox" class="select_hold" data-id="[% hold.reserve_id | html %]" /></td> >- <td style="min-width:185px;" data-order="[% priority | html %]"> >- <div> >+ <td style="min-width:190px;" data-order="[% priority | html %]"> >+ <div class="priority_container"> > <input type="hidden" name="reserve_id" value="[% hold.reserve_id | html %]" /> > <input type="hidden" name="borrowernumber" value="[% hold.borrowernumber | html %]" /> > <input type="hidden" name="biblionumber" value="[% hold.biblionumber | html %]" /> > [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] > [% IF Koha.Preference('HoldsSplitQueue') == "nothing" && !hold.found %] >- <label for="rank-request_[% hold.reserve_id | html %]">Change priority to:</label> >+ <label for="rank-request_[% hold.reserve_id | html %]">Change priority to: </label> > <select name="rank-request" id="rank-request_[% hold.reserve_id | html %]" class="rank-request" data-hold-id="[% hold.reserve_id | html %]"> > [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] > [% FOREACH priority IN all_priorities %] >@@ -88,10 +88,8 @@ > [% ELSE %] > <input type="hidden" name="rank-request" class="rank-request" value="[% hold.priority | html %]" data-hold-id="[% hold.reserve_id | html %]" /> > [% END %] >- <div> >- <label for="current_priority_[% hold.reserve_id | html %]">Current priority: </label> >- <span id="current_priority_[% hold.reserve_id | html %]" class="current_priority badge text-bg-info">[% hold.priority | html %]</span> >- </div> >+ <label for="current_priority_[% hold.reserve_id | html %]">Current priority: </label> >+ <span id="current_priority_[% hold.reserve_id | html %]" class="current_priority badge text-bg-info">[% hold.priority | html %]</span> > </div> > </td> > [%- IF ( CAN_user_reserveforothers_modify_holds_priority ) -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 02dd27aa3b9..32d3c9d0ca7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -105,12 +105,19 @@ > :disabled { > opacity: 0.5; > } >+ .priority_container { >+ display: grid; >+ grid-template-columns: 2fr 1fr; >+ align-items: center; >+ } > .current_priority { >+ margin-left: 1ch; > width: 50px; > text-align: left; > margin-top: 5px; > } > .rank-request { >+ margin-left: 1ch; > width: 50px; > } > </style> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40706
: 185803