Bugzilla – Attachment 185825 Details for
Bug 9762
Log circulation overrides
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9762: (follow-up) Fix failing CanBookBeIssued test
Bug-9762-follow-up-Fix-failing-CanBookBeIssued-tes.patch (text/plain), 1.64 KB, created by
Martin Renvoize (ashimema)
on 2025-08-27 14:35:51 UTC
(
hide
)
Description:
Bug 9762: (follow-up) Fix failing CanBookBeIssued test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-08-27 14:35:51 UTC
Size:
1.64 KB
patch
obsolete
>From 542d847cc7e7f1dc922981141ef9c4e3a72c370d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Wed, 27 Aug 2025 14:32:58 +0100 >Subject: [PATCH] Bug 9762: (follow-up) Fix failing CanBookBeIssued test > >The test was failing because: >1. IssuingInProcess preference was not explicitly set, affecting the code path for message logging >2. The patron category had a random noissuescharge value that overrode the system preference > >Fixed by: >- Setting IssuingInProcess to 0 to ensure correct code path >- Setting patron category noissuescharge to undef to use system preference > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > t/db_dependent/Circulation/CanBookBeIssued.t | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation/CanBookBeIssued.t b/t/db_dependent/Circulation/CanBookBeIssued.t >index dbb686ff497..2f84b4a1cf0 100755 >--- a/t/db_dependent/Circulation/CanBookBeIssued.t >+++ b/t/db_dependent/Circulation/CanBookBeIssued.t >@@ -63,7 +63,8 @@ my $patron_category = $builder->build( > { > source => 'Category', > value => { >- category_type => 'P', >+ category_type => 'P', >+ noissuescharge => undef, > } > } > ); >@@ -176,6 +177,7 @@ is( $message_log->[0], 'too many checkout', 'Checkout limit reached message disp > t::lib::Mocks::mock_preference( 'AllFinesNeedOverride', 0 ); > t::lib::Mocks::mock_preference( 'AllowFineOverride', 1 ); > t::lib::Mocks::mock_preference( 'noissuescharge', 5 ); >+t::lib::Mocks::mock_preference( 'IssuingInProcess', 0 ); > > $dbh->do(q|DELETE FROM circulation_rules|); > >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9762
:
149554
|
156222
|
163847
|
164022
|
164067
|
164068
|
164302
|
164387
|
164426
|
164479
|
164508
|
164509
|
164510
|
164519
|
170271
|
170272
|
170273
|
176742
|
177294
|
177295
|
177296
|
178029
|
178030
|
178031
|
178036
|
181303
|
181304
|
181305
|
181306
|
181307
|
181308
|
181340
|
181341
|
181342
|
181343
|
181344
|
181345
|
181346
|
181357
|
181358
|
181359
|
181360
|
181361
|
181362
|
181363
|
181371
|
181381
|
181390
|
181393
|
181545
|
181546
|
185118
|
185314
|
185315
|
185316
|
185317
|
185318
|
185319
|
185320
|
185321
|
185322
|
185323
|
185815
|
185816
|
185817
|
185818
|
185819
|
185820
|
185821
|
185822
|
185823
|
185824
| 185825 |
185826
|
185827