Bugzilla – Attachment 185863 Details for
Bug 40656
bookings/list.tt needs to be refactored
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40656: (follow-up) Always display Status column in bookings table
Bug-40656-follow-up-Always-display-Status-column-i.patch (text/plain), 2.38 KB, created by
Martin Renvoize (ashimema)
on 2025-08-29 06:49:42 UTC
(
hide
)
Description:
Bug 40656: (follow-up) Always display Status column in bookings table
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-08-29 06:49:42 UTC
Size:
2.38 KB
patch
obsolete
>From 685690cda8f26760366f933f8892d741378e3571 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Fri, 29 Aug 2025 07:40:27 +0100 >Subject: [PATCH] Bug 40656: (follow-up) Always display Status column in > bookings table > >The Status column was previously only visible when filters were applied, >making the interface inconsistent and potentially confusing. This change >ensures the Status column is always displayed regardless of filter state. > >Test plan: >1. Navigate to a biblio record with bookings >2. Go to the Bookings tab >3. Verify the Status column is visible in the bookings table >4. Apply filters (Include expired/Include cancelled) >5. Verify the Status column remains visible >6. Remove all filters >7. Confirm the Status column is still visible and shows appropriate > status badges (New, Pending, Active, etc.) > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >index 56584307bbc..b779c888967 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >@@ -212,12 +212,7 @@ > > const additional_filters = AdditionalFilters.init(["filter-expired", "filter-cancelled"]) > .onChange((filters, { anyFiltersNotApplied }) => { >- bookings_table.DataTable().ajax.reload(() => { >- bookings_table >- .DataTable() >- .column("status:name") >- .visible(anyFiltersNotApplied, false); >- }); >+ bookings_table.DataTable().ajax.reload(); > }) > .build({ > end_date: ({ filters, isNotApplied }) => { >@@ -258,7 +253,7 @@ > name: "status", > searchable: false, > orderable: false, >- visible: false, >+ visible: true, > render: function (data, type, row, meta) { > const isExpired = date => dayjs(date).isBefore(new Date()); > const isActive = (startDate, endDate) => { >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40656
:
185468
|
185469
|
185470
|
185860
|
185861
|
185862
| 185863 |
185864