Bugzilla – Attachment 185885 Details for
Bug 40671
Expand Koha::Hold->revert_waiting to handle all found statuses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40671: (QA follow-up) Fix hardcoded currency symbol
Bug-40671-QA-follow-up-Fix-hardcoded-currency-symb.patch (text/plain), 1.70 KB, created by
Marcel de Rooy
on 2025-08-29 08:06:42 UTC
(
hide
)
Description:
Bug 40671: (QA follow-up) Fix hardcoded currency symbol
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-08-29 08:06:42 UTC
Size:
1.70 KB
patch
obsolete
>From 4f5abf6eebb4b211c376428e55e09162571d269a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 29 Aug 2025 09:58:35 +0200 >Subject: [PATCH] Bug 40671: (QA follow-up) Fix hardcoded currency symbol >Content-Type: text/plain; charset=utf-8 > >It could be before or after the amount. Assuming that it does not >contain digits itself ;) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/SIP/Transaction.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t >index e77202c8b6..8fcca7740c 100755 >--- a/t/db_dependent/SIP/Transaction.t >+++ b/t/db_dependent/SIP/Transaction.t >@@ -702,8 +702,8 @@ subtest do_checkin => sub { > $item->barcode, C4::SIP::Sip::timestamp, undef, $library->branchcode, undef, undef, > $server->{account} > ); >- is( >- $circ->{screen_msg}, 'You owe $12.00 for this item.', >+ like( >+ $circ->{screen_msg}, qr/^You owe \D*12\D/, > "The fine is displayed on checkin when show_outstanding_amount is enabled" > ); > >@@ -943,7 +943,7 @@ subtest do_checkout_with_patron_blocked => sub { > > $server->{account}->{show_outstanding_amount} = 1; > $circ = $ils->checkout( $fines_patron->cardnumber, $item->barcode, undef, undef, $server->{account} ); >- is( $circ->{screen_msg}, 'Patron has fines - You owe $10.00.', "Got correct fines with amount screen message" ); >+ like( $circ->{screen_msg}, qr/Patron has fines - You owe \D*10\D/, "Got correct fines with amount screen message" ); > my $debarred_patron = $builder->build_object( > { > class => 'Koha::Patrons', >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40671
:
185541
|
185542
|
185562
|
185563
|
185883
|
185884
| 185885