Attachment 18591 Details for Bug 10283 – Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings

[patch] Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings

Bug-10283-Hide-many-items-on-second-tab-when-using.patch (text/plain), 3.04 KB, created by Srdjan Jankovic on 2013-06-03 00:24:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Srdjan Jankovic

Created: 2013-06-03 00:24:54 UTC

Size: 3.04 KB

patch

obsolete

>From 9a6002f8c876a898fc554456d72e2900d0608365 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Mon, 20 May 2013 09:53:38 +0200
>Subject: [PATCH] Bug 10283: Hide "many items" on second tab when using
> OpacSeparateHoldings
>
>If there are over 50 items in the holdings or Other holdings tab, the
>warning and link 'This record has many physical items. Click here to
>view them all.' is only shown for the first tab.
>
>Test plan:
>- Switch on the OpacSeparateHoldings pref.
>- Go on a biblio detail page at the OPAC with more than 50 items
>- Check that the 'view all' link appears on the second tab.
>
>Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
>---
> koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 10 +++++++---
> opac/opac-detail.pl                                |  5 ++++-
> 2 files changed, 11 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>index 1effd07..bfd784f 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
>@@ -1018,8 +1018,8 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
> 
> <div id="holdings">
> [% IF ( itemloop.size ) %]
>-    [% IF ( lotsofitems ) %]
>-	<p>This record has many physical items. <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber %]&amp;viewallitems=1#holdings">Click here to view them all.</a></p>
>+    [% IF ( lotsofholdingsitems ) %]
>+        <p>This record has many physical items. <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber %]&amp;viewallitems=1#holdings">Click here to view them all.</a></p>
>     [% ELSE %]
>         [% INCLUDE items_table items=itemloop tab="holdings" %]
>     [% END %]
>@@ -1054,7 +1054,11 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
> [% IF (SeparateHoldings) %]
>     <div id="otherholdings">
>         [% IF (otheritemloop.size) %]
>-            [% INCLUDE items_table items=otheritemloop tab="otherholdings" %]
>+            [% IF lotsofothersholdingsitems %]
>+                <p>This record has many physical items. <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber %]&amp;viewallitems=1#otherholdings">Click here to view them all.</a></p>
>+            [% ELSE %]
>+                [% INCLUDE items_table items=otheritemloop tab="otherholdings" %]
>+            [% END %]
>         [% ELSE %]
>             No other items.
>         [% END %]
>diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
>index 9d0851f..b4ad6a5 100755
>--- a/opac/opac-detail.pl
>+++ b/opac/opac-detail.pl
>@@ -624,7 +624,10 @@ if (scalar(@itemloop) == 0 || scalar(@otheritemloop) == 0) {
> # TODO: The limit of 50 could be a syspref
> my $viewallitems = $query->param('viewallitems');
> if (scalar(@itemloop) >= 50 && !$viewallitems) {
>-    $template->param('lotsofitems' => 1);
>+    $template->param('lotsofholdingsitems' => 1);
>+}
>+if (scalar(@otheritemloop) >= 50 && !$viewallitems) {
>+    $template->param('lotsofothersholdingsitems' => 1);
> }
> 
> ## get notes and subjects from MARC record
>-- 
>1.8.1.2

Actions: View | Diff | Splinter Review

Attachments on bug 10283: 18246 | 18591 | 19043