Bugzilla – Attachment 18593 Details for
Bug 10354
Don't show optgroup Libraries when no search groups are defined
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-Off] Bug 10354 - Don't show optgroup Libraries when no search groups are defined
Signed-Off-Bug-10354---Dont-show-optgroup-Librarie.patch (text/plain), 2.28 KB, created by
Srdjan Jankovic
on 2013-06-03 01:47:06 UTC
(
hide
)
Description:
[Signed-Off] Bug 10354 - Don't show optgroup Libraries when no search groups are defined
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2013-06-03 01:47:06 UTC
Size:
2.28 KB
patch
obsolete
>From 14e014865c22189a9f7fb31ffec79e2040c002fb Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 31 May 2013 09:54:34 -0400 >Subject: [PATCH] [Signed-Off] Bug 10354 - Don't show optgroup Libraries when > no search groups are defined > >In the OPAC, if there are no search groups defined, there's no reason to >embed library choices inside an <optgroup>. <optgroup> should only be >used to differentiate the list of individual libraries from search >groups. This patch removes the <optgroup> when no search groups are >enabled. > >To test, apply the patch and: > >- Enable OpacAddMastheadLibraryPulldown. >- Create a library search group in Administration -> > Libraries and Groups and enable it by checking the "show in search > pulldown" box. >- View the library pulldown in the OPAC search bar. Libraries and groups > should be separated into <optgroup>s. >- Disable your library search group and refresh the OPAC page. The > pulldown of libraries should now display libraries with no <optgroup>. > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >--- > koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc >index f9edb01..651e669 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc >@@ -87,13 +87,13 @@ > [% IF ( OpacAddMastheadLibraryPulldown ) %] > <select name="branch_group_limit" id="select_library" class="left"> > <option value="">All libraries</option> >- <optgroup label="Libraries"> >+ [% IF BranchCategoriesLoop %]<optgroup label="Libraries">[% END %] > [% FOREACH BranchesLoo IN BranchesLoop %] > [% IF ( BranchesLoo.selected ) %]<option selected="selected" value="branch:[% BranchesLoo.value %]">[% BranchesLoo.branchname %]</option> > [% ELSE %]<option value="branch:[% BranchesLoo.value %]">[% BranchesLoo.branchname %]</option>[% END %] > [% END %] >- </optgroup> > [% IF BranchCategoriesLoop %] >+ </optgroup> > <optgroup label="Groups"> > [% FOREACH bc IN BranchCategoriesLoop %] > [% IF ( bc.selected ) %] >-- >1.8.1.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10354
:
18544
|
18593
|
18732
|
18735