Bugzilla – Attachment 185987 Details for
Bug 39190
Rework new (S)FTP classes to be polymorphic classes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39190: Rename 'sftp_servers' to 'file_transports'
Bug-39190-Rename-sftpservers-to-filetransports.patch (text/plain), 4.51 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-08-29 21:24:03 UTC
(
hide
)
Description:
Bug 39190: Rename 'sftp_servers' to 'file_transports'
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-08-29 21:24:03 UTC
Size:
4.51 KB
patch
obsolete
>From b6591b5d3a3459603495ceeb911d4f71cfa86db6 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 29 Aug 2025 17:29:23 -0300 >Subject: [PATCH] Bug 39190: Rename 'sftp_servers' to 'file_transports' > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../bug_35761-add_SFTP_tables_and_perm.pl | 12 ++++++------ > installer/data/mysql/kohastructure.sql | 6 +++--- > installer/data/mysql/mandatory/userpermissions.sql | 4 ++-- > 3 files changed, 11 insertions(+), 11 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_35761-add_SFTP_tables_and_perm.pl b/installer/data/mysql/atomicupdate/bug_35761-add_SFTP_tables_and_perm.pl >index f0acdbda2e6..653254df040 100755 >--- a/installer/data/mysql/atomicupdate/bug_35761-add_SFTP_tables_and_perm.pl >+++ b/installer/data/mysql/atomicupdate/bug_35761-add_SFTP_tables_and_perm.pl >@@ -2,7 +2,7 @@ use Modern::Perl; > > return { > bug_number => "35761", >- description => "Add new table and permission for generalised SFTP", >+ description => "Add new table and permission for generalised file transports", > up => sub { > my ($args) = @_; > my ( $dbh, $out ) = @$args{qw(dbh out)}; >@@ -10,15 +10,15 @@ return { > $dbh->do( > q{ > INSERT IGNORE INTO permissions (module_bit, code, description) >- VALUES (3, 'manage_sftp_servers', 'Manage FTP/SFTP servers configuration'); >+ VALUES (3, 'manage_file_transports', 'Manage file transports configuration'); > } > ); >- say $out "Added new manage_sftp_servers permission"; >+ say $out "Added new permission 'manage_file_transports'"; > >- unless ( TableExists('sftp_servers') ) { >+ unless ( TableExists('file_transports') ) { > $dbh->do( > q { >- CREATE TABLE `sftp_servers` ( >+ CREATE TABLE `file_transports` ( > `id` int(11) NOT NULL AUTO_INCREMENT, > `name` varchar(80) NOT NULL, > `host` varchar(80) NOT NULL DEFAULT 'localhost', >@@ -38,7 +38,7 @@ return { > ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; > } > ); >- say $out "Added new sftp_servers table"; >+ say $out "Added new table 'file_transports"; > } > }, > }; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index e5aa96ff80f..cf951b09a56 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -5967,13 +5967,13 @@ CREATE TABLE `sessions` ( > /*!40101 SET character_set_client = @saved_cs_client */; > > -- >--- Table structure for table `sftp_servers` >+-- Table structure for table `file_transports` > -- > >-DROP TABLE IF EXISTS `sftp_servers`; >+DROP TABLE IF EXISTS `file_transports`; > /*!40101 SET @saved_cs_client = @@character_set_client */; > /*!40101 SET character_set_client = utf8 */; >-CREATE TABLE `sftp_servers` ( >+CREATE TABLE `file_transports` ( > `id` int(11) NOT NULL AUTO_INCREMENT, > `name` varchar(80) NOT NULL, > `host` varchar(80) NOT NULL DEFAULT 'localhost', >diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql >index 22720c04876..8252fb44202 100644 >--- a/installer/data/mysql/mandatory/userpermissions.sql >+++ b/installer/data/mysql/mandatory/userpermissions.sql >@@ -39,7 +39,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES > ( 3, 'manage_additional_fields', 'Add, edit, or delete additional custom fields for baskets or subscriptions (also requires order_manage or edit_subscription permissions)'), > ( 3, 'manage_keyboard_shortcuts', 'Manage keyboard shortcuts for the advanced cataloging editor'), > ( 3, 'manage_smtp_servers', 'Manage SMTP servers configuration'), >- ( 3, 'manage_sftp_servers', 'Manage FTP/SFTP servers configuration'), >+ ( 3, 'manage_file_transports', 'Manage file transports configuration'), > ( 3, 'manage_background_jobs', 'Manage background jobs'), > ( 3, 'manage_curbside_pickups', 'Manage curbside pickups'), > ( 3, 'manage_search_filters', 'Manage custom search filters'), >@@ -167,4 +167,4 @@ INSERT INTO permissions (module_bit, code, description) VALUES > (25, 'takepayment', 'Access the point of sale page and take payments'), > (26, 'manage_problem_reports', 'Manage OPAC problem reports'), > (27, 'manage_recalls', 'Manage recalls for patrons') >-; >\ No newline at end of file >+; >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39190
:
178555
|
178556
|
178557
|
178558
|
178559
|
178560
|
178561
|
178562
|
178563
|
178564
|
178565
|
178566
|
178567
|
178568
|
178569
|
178570
|
178571
|
179252
|
179253
|
179254
|
179255
|
179256
|
179257
|
179258
|
179259
|
179260
|
179261
|
179262
|
179263
|
179264
|
179265
|
179266
|
179267
|
179268
|
179396
|
179397
|
179398
|
179399
|
179400
|
179401
|
179402
|
179403
|
179404
|
179405
|
179406
|
179407
|
179408
|
179409
|
179410
|
179411
|
179412
|
179413
|
179589
|
179590
|
179591
|
179592
|
179593
|
179594
|
179595
|
179596
|
179597
|
179598
|
179599
|
179600
|
179601
|
179602
|
179603
|
179604
|
179605
|
179606
|
179646
|
179647
|
179648
|
179649
|
179650
|
179651
|
179652
|
179653
|
179654
|
179655
|
179656
|
179657
|
179658
|
179659
|
179660
|
179661
|
179662
|
179663
|
179992
|
179993
|
179994
|
179995
|
179996
|
179997
|
179998
|
179999
|
180000
|
180001
|
180002
|
180003
|
180004
|
180005
|
180006
|
180010
|
180011
|
180012
|
180013
|
180014
|
180015
|
180016
|
180017
|
180018
|
180019
|
180020
|
180021
|
180022
|
180023
|
180024
|
180025
|
185014
|
185015
|
185016
|
185017
|
185018
|
185019
|
185020
|
185021
|
185022
|
185023
|
185024
|
185025
|
185026
|
185027
|
185028
|
185029
|
185972
|
185973
|
185974
|
185975
|
185976
|
185977
|
185978
|
185979
|
185980
|
185981
|
185982
|
185983
|
185984
|
185985
|
185986
| 185987 |
185988
|
185989
|
185990
|
185994
|
185995
|
185996
|
185997
|
185998