Bugzilla – Attachment 185989 Details for
Bug 39190
Rework new (S)FTP classes to be polymorphic classes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39190: Adjust permission across the board
Bug-39190-Adjust-permission-across-the-board.patch (text/plain), 9.20 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-08-29 21:24:13 UTC
(
hide
)
Description:
Bug 39190: Adjust permission across the board
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-08-29 21:24:13 UTC
Size:
9.20 KB
patch
obsolete
>From c4e373296d8953ac1f428538500b7cad22079121 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 29 Aug 2025 17:48:35 -0300 >Subject: [PATCH] Bug 39190: Adjust permission across the board > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > admin/sftp_servers.pl | 2 +- > api/v1/swagger/paths/config_sftp_servers.yaml | 10 +++++----- > .../intranet-tmpl/prog/en/includes/admin-menu.inc | 4 ++-- > .../intranet-tmpl/prog/en/includes/permissions.inc | 4 ++-- > .../intranet-tmpl/prog/en/modules/admin/admin-home.tt | 4 ++-- > t/Koha/Auth/Permissions.t | 2 +- > 6 files changed, 13 insertions(+), 13 deletions(-) > >diff --git a/admin/sftp_servers.pl b/admin/sftp_servers.pl >index 1be83acea9a..eb41983b62e 100755 >--- a/admin/sftp_servers.pl >+++ b/admin/sftp_servers.pl >@@ -36,7 +36,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > template_name => "admin/sftp_servers.tt", > query => $input, > type => "intranet", >- flagsrequired => { parameters => 'manage_sftp_servers' }, >+ flagsrequired => { parameters => 'manage_file_transports' }, > } > ); > >diff --git a/api/v1/swagger/paths/config_sftp_servers.yaml b/api/v1/swagger/paths/config_sftp_servers.yaml >index e634760a637..4e6919192b2 100644 >--- a/api/v1/swagger/paths/config_sftp_servers.yaml >+++ b/api/v1/swagger/paths/config_sftp_servers.yaml >@@ -47,7 +47,7 @@ > $ref: "../swagger.yaml#/definitions/error" > x-koha-authorization: > permissions: >- parameters: manage_sftp_servers >+ parameters: manage_file_transports > post: > x-mojo-to: Config::SFTP::Servers#add > operationId: addSFTPServer >@@ -97,7 +97,7 @@ > $ref: "../swagger.yaml#/definitions/error" > x-koha-authorization: > permissions: >- parameters: manage_sftp_servers >+ parameters: manage_file_transports > "/config/sftp_servers/{sftp_server_id}": > get: > x-mojo-to: Config::SFTP::Servers#get >@@ -139,7 +139,7 @@ > $ref: "../swagger.yaml#/definitions/error" > x-koha-authorization: > permissions: >- parameters: manage_sftp_servers >+ parameters: manage_file_transports > put: > x-mojo-to: Config::SFTP::Servers#update > operationId: updateSFTPServer >@@ -190,7 +190,7 @@ > $ref: "../swagger.yaml#/definitions/error" > x-koha-authorization: > permissions: >- parameters: manage_sftp_servers >+ parameters: manage_file_transports > delete: > x-mojo-to: Config::SFTP::Servers#delete > operationId: deleteSFTPServer >@@ -233,4 +233,4 @@ > $ref: "../swagger.yaml#/definitions/error" > x-koha-authorization: > permissions: >- parameters: manage_sftp_servers >\ No newline at end of file >+ parameters: manage_file_transports >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >index 8e00a787130..90fc4a3fbff 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >@@ -145,7 +145,7 @@ > </ul> > [% END %] > >- [% IF ( CAN_user_parameters_manage_identity_providers || CAN_user_parameters_manage_smtp_servers ||CAN_user_parameters_manage_sftp_servers || CAN_user_parameters_manage_search_targets || CAN_user_parameters_manage_didyoumean || CAN_user_parameters_manage_column_config || CAN_user_parameters_manage_audio_alerts || ( CAN_user_parameters_manage_sms_providers && Koha.Preference('SMSSendDriver') == 'Email' ) || CAN_user_parameters_manage_usage_stats || CAN_user_parameters_manage_additional_fields || ( Koha.Preference('EnableAdvancedCatalogingEditor') && CAN_user_parameters_manage_keyboard_shortcuts ) ) %] >+ [% IF ( CAN_user_parameters_manage_identity_providers || CAN_user_parameters_manage_smtp_servers ||CAN_user_parameters_manage_file_transports || CAN_user_parameters_manage_search_targets || CAN_user_parameters_manage_didyoumean || CAN_user_parameters_manage_column_config || CAN_user_parameters_manage_audio_alerts || ( CAN_user_parameters_manage_sms_providers && Koha.Preference('SMSSendDriver') == 'Email' ) || CAN_user_parameters_manage_usage_stats || CAN_user_parameters_manage_additional_fields || ( Koha.Preference('EnableAdvancedCatalogingEditor') && CAN_user_parameters_manage_keyboard_shortcuts ) ) %] > <h5>Additional parameters</h5> > <ul> > [% IF ( CAN_user_parameters_manage_identity_providers) %] >@@ -158,7 +158,7 @@ > [% IF ( CAN_user_parameters_manage_smtp_servers ) %] > <li><a href="/cgi-bin/koha/admin/smtp_servers.pl">SMTP servers</a></li> > [% END %] >- [% IF ( CAN_user_parameters_manage_sftp_servers ) %] >+ [% IF ( CAN_user_parameters_manage_file_transports ) %] > <li><a href="/cgi-bin/koha/admin/sftp_servers.pl">FTP/SFTP servers</a></li> > [% END %] > [% IF ( CAN_user_parameters_manage_didyoumean ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >index 9dfcb1df2f0..1c5f03a366b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >@@ -193,8 +193,8 @@ > [%- CASE 'manage_smtp_servers' -%] > <span class="sub_permission manage_manage_smtp_servers_subpermission"> Manage SMTP servers </span> > <span class="permissioncode">([% name | html %])</span> >- [%- CASE 'manage_sftp_servers' -%] >- <span class="sub_permission manage_manage_sftp_servers_subpermission"> Manage FTP/SFTP servers </span> >+ [%- CASE 'manage_file_transports' -%] >+ <span class="sub_permission manage_manage_file_transports_subpermission"> Manage FTP/SFTP servers </span> > <span class="permissioncode">([% name | html %])</span> > [%- CASE 'manage_column_config' -%] > <span class="sub_permission manage_column_config_subpermission"> Manage column configuration </span> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >index b72160396f9..e4934641293 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >@@ -254,7 +254,7 @@ > </dl> > [% END %] > >- [% IF ( ( CAN_user_parameters_manage_identity_providers || CAN_user_parameters_manage_smtp_servers || CAN_user_parameters_manage_sftp_servers || CAN_user_parameters_manage_search_targets || CAN_user_parameters_manage_didyoumean || CAN_user_parameters_manage_column_config || CAN_user_parameters_manage_audio_alerts || CAN_user_parameters_manage_sms_providers && Koha.Preference('SMSSendDriver') == 'Email' ) || CAN_user_parameters_manage_usage_stats || CAN_user_parameters_manage_additional_fields || CAN_user_parameters_manage_mana || (Koha.Preference('EnableAdvancedCatalogingEditor') && CAN_user_parameters_manage_keyboard_shortcuts) ) %] >+ [% IF ( ( CAN_user_parameters_manage_identity_providers || CAN_user_parameters_manage_smtp_servers || CAN_user_parameters_manage_file_transports || CAN_user_parameters_manage_search_targets || CAN_user_parameters_manage_didyoumean || CAN_user_parameters_manage_column_config || CAN_user_parameters_manage_audio_alerts || CAN_user_parameters_manage_sms_providers && Koha.Preference('SMSSendDriver') == 'Email' ) || CAN_user_parameters_manage_usage_stats || CAN_user_parameters_manage_additional_fields || CAN_user_parameters_manage_mana || (Koha.Preference('EnableAdvancedCatalogingEditor') && CAN_user_parameters_manage_keyboard_shortcuts) ) %] > <h3>Additional parameters</h3> > <dl> > <!-- <dt><a href="/cgi-bin/koha/admin/printers.pl">Network Printers</a></dt> >@@ -273,7 +273,7 @@ > <dt><a href="/cgi-bin/koha/admin/smtp_servers.pl">SMTP servers</a></dt> > <dd>Define which SMTP servers to use</dd> > [% END %] >- [% IF ( CAN_user_parameters_manage_sftp_servers ) %] >+ [% IF ( CAN_user_parameters_manage_file_transports ) %] > <dt><a href="/cgi-bin/koha/admin/sftp_servers.pl">FTP/SFTP servers</a></dt> > <dd>Define available FTP/SFTP servers</dd> > [% END %] >diff --git a/t/Koha/Auth/Permissions.t b/t/Koha/Auth/Permissions.t >index 86a36bc03a7..2f97b5c408e 100755 >--- a/t/Koha/Auth/Permissions.t >+++ b/t/Koha/Auth/Permissions.t >@@ -209,7 +209,7 @@ subtest 'superlibrarian tests' => sub { > 'CAN_user_parameters_manage_search_targets' => 1, > 'CAN_user_parameters_manage_sms_providers' => 1, > 'CAN_user_parameters_manage_smtp_servers' => 1, >- 'CAN_user_parameters_manage_sftp_servers' => 1, >+ 'CAN_user_parameters_manage_file_transports' => 1, > 'CAN_user_parameters_manage_sysprefs' => 1, > 'CAN_user_parameters_manage_transfers' => 1, > 'CAN_user_parameters_manage_usage_stats' => 1, >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39190
:
178555
|
178556
|
178557
|
178558
|
178559
|
178560
|
178561
|
178562
|
178563
|
178564
|
178565
|
178566
|
178567
|
178568
|
178569
|
178570
|
178571
|
179252
|
179253
|
179254
|
179255
|
179256
|
179257
|
179258
|
179259
|
179260
|
179261
|
179262
|
179263
|
179264
|
179265
|
179266
|
179267
|
179268
|
179396
|
179397
|
179398
|
179399
|
179400
|
179401
|
179402
|
179403
|
179404
|
179405
|
179406
|
179407
|
179408
|
179409
|
179410
|
179411
|
179412
|
179413
|
179589
|
179590
|
179591
|
179592
|
179593
|
179594
|
179595
|
179596
|
179597
|
179598
|
179599
|
179600
|
179601
|
179602
|
179603
|
179604
|
179605
|
179606
|
179646
|
179647
|
179648
|
179649
|
179650
|
179651
|
179652
|
179653
|
179654
|
179655
|
179656
|
179657
|
179658
|
179659
|
179660
|
179661
|
179662
|
179663
|
179992
|
179993
|
179994
|
179995
|
179996
|
179997
|
179998
|
179999
|
180000
|
180001
|
180002
|
180003
|
180004
|
180005
|
180006
|
180010
|
180011
|
180012
|
180013
|
180014
|
180015
|
180016
|
180017
|
180018
|
180019
|
180020
|
180021
|
180022
|
180023
|
180024
|
180025
|
185014
|
185015
|
185016
|
185017
|
185018
|
185019
|
185020
|
185021
|
185022
|
185023
|
185024
|
185025
|
185026
|
185027
|
185028
|
185029
|
185972
|
185973
|
185974
|
185975
|
185976
|
185977
|
185978
|
185979
|
185980
|
185981
|
185982
|
185983
|
185984
|
185985
|
185986
|
185987
|
185988
| 185989 |
185990
|
185994
|
185995
|
185996
|
185997
|
185998