Bugzilla – Attachment 185990 Details for
Bug 39190
Rework new (S)FTP classes to be polymorphic classes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39190: Fix circular dependency causing C3 MRO failures
Bug-39190-Fix-circular-dependency-causing-C3-MRO-f.patch (text/plain), 1.39 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-08-29 21:24:18 UTC
(
hide
)
Description:
Bug 39190: Fix circular dependency causing C3 MRO failures
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-08-29 21:24:18 UTC
Size:
1.39 KB
patch
obsolete
>From fcc9299605e8d0be5aae91f9619cc0d69e45d7c5 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 29 Aug 2025 18:03:39 -0300 >Subject: [PATCH] Bug 39190: Fix circular dependency causing C3 MRO failures >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Resolved circular dependency chain: >Transport.pm â TestTransport.pm â Transports.pm â SFTP.pm â Transport.pm > >Changed 'use Koha::BackgroundJob::TestTransport' to runtime 'require' >in the _post_store_trigger method to break the dependency cycle. > >This fixes the C3 method resolution order failures in >Koha::File::Transport::FTP and Koha::File::Transport::SFTP. >--- > Koha/File/Transport.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/File/Transport.pm b/Koha/File/Transport.pm >index dc4d1cf75ea..47ba6eea853 100644 >--- a/Koha/File/Transport.pm >+++ b/Koha/File/Transport.pm >@@ -25,7 +25,6 @@ use constant { > use JSON qw( decode_json encode_json ); > use List::MoreUtils qw( any ); > >-use Koha::BackgroundJob::TestTransport; > use Koha::Database; > use Koha::Exceptions::Object; > use Koha::Encryption; >@@ -80,6 +79,7 @@ sub store { > > # Enqueue a connection test > if ($changed_config) { >+ require Koha::BackgroundJob::TestTransport; > Koha::BackgroundJob::TestTransport->new->enqueue( { transport_id => $self->id } ); > } > >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39190
:
178555
|
178556
|
178557
|
178558
|
178559
|
178560
|
178561
|
178562
|
178563
|
178564
|
178565
|
178566
|
178567
|
178568
|
178569
|
178570
|
178571
|
179252
|
179253
|
179254
|
179255
|
179256
|
179257
|
179258
|
179259
|
179260
|
179261
|
179262
|
179263
|
179264
|
179265
|
179266
|
179267
|
179268
|
179396
|
179397
|
179398
|
179399
|
179400
|
179401
|
179402
|
179403
|
179404
|
179405
|
179406
|
179407
|
179408
|
179409
|
179410
|
179411
|
179412
|
179413
|
179589
|
179590
|
179591
|
179592
|
179593
|
179594
|
179595
|
179596
|
179597
|
179598
|
179599
|
179600
|
179601
|
179602
|
179603
|
179604
|
179605
|
179606
|
179646
|
179647
|
179648
|
179649
|
179650
|
179651
|
179652
|
179653
|
179654
|
179655
|
179656
|
179657
|
179658
|
179659
|
179660
|
179661
|
179662
|
179663
|
179992
|
179993
|
179994
|
179995
|
179996
|
179997
|
179998
|
179999
|
180000
|
180001
|
180002
|
180003
|
180004
|
180005
|
180006
|
180010
|
180011
|
180012
|
180013
|
180014
|
180015
|
180016
|
180017
|
180018
|
180019
|
180020
|
180021
|
180022
|
180023
|
180024
|
180025
|
185014
|
185015
|
185016
|
185017
|
185018
|
185019
|
185020
|
185021
|
185022
|
185023
|
185024
|
185025
|
185026
|
185027
|
185028
|
185029
|
185972
|
185973
|
185974
|
185975
|
185976
|
185977
|
185978
|
185979
|
185980
|
185981
|
185982
|
185983
|
185984
|
185985
|
185986
|
185987
|
185988
|
185989
| 185990 |
185994
|
185995
|
185996
|
185997
|
185998