Bugzilla – Attachment 185996 Details for
Bug 39190
Rework new (S)FTP classes to be polymorphic classes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39190: Rename admin interface from sftp_servers to file_transports
Bug-39190-Rename-admin-interface-from-sftpservers-.patch (text/plain), 13.18 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-08-30 15:35:54 UTC
(
hide
)
Description:
Bug 39190: Rename admin interface from sftp_servers to file_transports
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-08-30 15:35:54 UTC
Size:
13.18 KB
patch
obsolete
>From 9924297edb47ca499c507424f19af68850c76767 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Sat, 30 Aug 2025 12:05:07 -0300 >Subject: [PATCH] Bug 39190: Rename admin interface from sftp_servers to > file_transports > >Renamed admin interface files and URLs to reflect the evolution from >'SFTP servers' to 'File transports' functionality: > >- admin/sftp_servers.pl -> admin/file_transports.pl >- sftp_servers.tt -> file_transports.tt >- Updated all URL references in templates and admin menu >- Updated body id from admin_sftp_servers to admin_file_transports > >The functionality is now future-proof for the addition of new file >transports, so the naming should reflect his broader scope. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > admin/{sftp_servers.pl => file_transports.pl} | 2 +- > .../prog/en/includes/admin-menu.inc | 2 +- > .../prog/en/includes/permissions.inc | 2 +- > .../prog/en/modules/admin/admin-home.tt | 4 +- > .../{sftp_servers.tt => file_transports.tt} | 42 +++++++++---------- > 5 files changed, 26 insertions(+), 26 deletions(-) > rename admin/{sftp_servers.pl => file_transports.pl} (99%) > rename koha-tmpl/intranet-tmpl/prog/en/modules/admin/{sftp_servers.tt => file_transports.tt} (96%) > >diff --git a/admin/sftp_servers.pl b/admin/file_transports.pl >similarity index 99% >rename from admin/sftp_servers.pl >rename to admin/file_transports.pl >index eb41983b62e..a0fb042dd72 100755 >--- a/admin/sftp_servers.pl >+++ b/admin/file_transports.pl >@@ -33,7 +33,7 @@ my $op = $input->param('op') || 'list'; > > my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > { >- template_name => "admin/sftp_servers.tt", >+ template_name => "admin/file_transports.tt", > query => $input, > type => "intranet", > flagsrequired => { parameters => 'manage_file_transports' }, >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >index 90fc4a3fbff..1cc415df33b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc >@@ -159,7 +159,7 @@ > <li><a href="/cgi-bin/koha/admin/smtp_servers.pl">SMTP servers</a></li> > [% END %] > [% IF ( CAN_user_parameters_manage_file_transports ) %] >- <li><a href="/cgi-bin/koha/admin/sftp_servers.pl">FTP/SFTP servers</a></li> >+ <li><a href="/cgi-bin/koha/admin/file_transports.pl">File transports</a></li> > [% END %] > [% IF ( CAN_user_parameters_manage_didyoumean ) %] > <li><a href="/cgi-bin/koha/admin/didyoumean.pl">Did you mean?</a></li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >index 1c5f03a366b..0a19f29e43a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc >@@ -194,7 +194,7 @@ > <span class="sub_permission manage_manage_smtp_servers_subpermission"> Manage SMTP servers </span> > <span class="permissioncode">([% name | html %])</span> > [%- CASE 'manage_file_transports' -%] >- <span class="sub_permission manage_manage_file_transports_subpermission"> Manage FTP/SFTP servers </span> >+ <span class="sub_permission manage_manage_file_transports_subpermission"> Manage file transports </span> > <span class="permissioncode">([% name | html %])</span> > [%- CASE 'manage_column_config' -%] > <span class="sub_permission manage_column_config_subpermission"> Manage column configuration </span> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >index e4934641293..bf92a4c1f8c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >@@ -274,8 +274,8 @@ > <dd>Define which SMTP servers to use</dd> > [% END %] > [% IF ( CAN_user_parameters_manage_file_transports ) %] >- <dt><a href="/cgi-bin/koha/admin/sftp_servers.pl">FTP/SFTP servers</a></dt> >- <dd>Define available FTP/SFTP servers</dd> >+ <dt><a href="/cgi-bin/koha/admin/file_transports.pl">File transports</a></dt> >+ <dd>Define available file transport servers (FTP/SFTP)</dd> > [% END %] > [% IF ( CAN_user_parameters_manage_didyoumean ) %] > <dt><a href="/cgi-bin/koha/admin/didyoumean.pl">Did you mean?</a></dt> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/sftp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/file_transports.tt >similarity index 96% >rename from koha-tmpl/intranet-tmpl/prog/en/modules/admin/sftp_servers.tt >rename to koha-tmpl/intranet-tmpl/prog/en/modules/admin/file_transports.tt >index e49627d6ee4..9692ec4fc12 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/sftp_servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/file_transports.tt >@@ -6,20 +6,20 @@ > <title > >[% FILTER collapse %] > [% IF op == 'add_form' %] >- [% t("New FTP/SFTP server") | html %] >+ [% t("New file transport") | html %] > › > [% ELSIF op == 'edit_form' %] >- [% tx("Modify FTP/SFTP server '{sftp_server}'", { sftp_server = sftp_server.name }) | html %] >+ [% tx("Modify file transport '{sftp_server}'", { sftp_server = sftp_server.name }) | html %] > › > [% END %] >- [% t("FTP/SFTP Servers") | html %] >+ [% t("File transports") | html %] > › [% t("Administration") | html %] › [% t("Koha") | html %] > [% END %]</title > > > [% INCLUDE 'doc-head-close.inc' %] > </head> > >-<body id="admin_sftp_servers" class="admin"> >+<body id="admin_file_transports" class="admin"> > [% WRAPPER 'header.inc' %] > [% INCLUDE 'prefs-admin-search.inc' %] > [% END %] >@@ -32,21 +32,21 @@ > > [% IF op == 'add_form' || op == 'edit_form' %] > [% WRAPPER breadcrumb_item %] >- <a href="/cgi-bin/koha/admin/sftp_servers.pl">FTP/SFTP servers</a> >+ <a href="/cgi-bin/koha/admin/file_transports.pl">File transports</a> > [% END %] > [% END %] > > [% IF op == 'add_form' %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- <span>New FTP/SFTP server</span> >+ <span>New file transport</span> > [% END %] > [% ELSIF op == 'edit_form' %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- [% tx("Modify FTP/SFTP server '{sftp_server}'", { sftp_server = sftp_server.name }) | html %] >+ [% tx("Modify file transport '{sftp_server}'", { sftp_server = sftp_server.name }) | html %] > [% END %] > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- <span>FTP/SFTP servers</span> >+ <span>File transports</span> > [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] >@@ -128,9 +128,9 @@ > </div> > <!-- END Modal --> > >- <h1>New FTP/SFTP server</h1> >+ <h1>New file transport</h1> > >- <form action="/cgi-bin/koha/admin/sftp_servers.pl" id="add" name="add" class="validated" method="post"> >+ <form action="/cgi-bin/koha/admin/file_transports.pl" id="add" name="add" class="validated" method="post"> > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="op" value="cud-add" /> > <fieldset class="rows"> >@@ -216,7 +216,7 @@ > </fieldset> > <fieldset class="action"> > <a id="confirm_key_accept_submit" data-bs-target="#confirm_key_accept" class="btn btn-primary" data-bs-toggle="modal">Submit</a> >- <a class="cancel" href="/cgi-bin/koha/admin/sftp_servers.pl">Cancel</a> >+ <a class="cancel" href="/cgi-bin/koha/admin/file_transports.pl">Cancel</a> > </fieldset> > </form> > [% END %] >@@ -269,9 +269,9 @@ > </div> > <!-- END Modal --> > >- <h1>[% tx("Modify FTP/SFTP server '{sftp_server}'", { sftp_server = sftp_server.name }) | html %]</h1> >+ <h1>[% tx("Modify file transport '{sftp_server}'", { sftp_server = sftp_server.name }) | html %]</h1> > >- <form action="/cgi-bin/koha/admin/sftp_servers.pl" id="edit_save" name="edit_save" class="validated" method="post"> >+ <form action="/cgi-bin/koha/admin/file_transports.pl" id="edit_save" name="edit_save" class="validated" method="post"> > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="op" value="cud-edit_save" /> > <input type="hidden" name="sftp_server_id" value="[%- sftp_server.id | html -%]" /> >@@ -394,23 +394,23 @@ > </fieldset> > <fieldset class="action"> > <a id="confirm_key_accept_submit" data-bs-target="#confirm_key_accept" class="btn btn-primary" data-bs-toggle="modal">Submit</a> >- <a class="cancel" href="/cgi-bin/koha/admin/sftp_servers.pl">Cancel</a> >+ <a class="cancel" href="/cgi-bin/koha/admin/file_transports.pl">Cancel</a> > </fieldset> > </form> > [% END %] > > [% IF op == 'list' %] > <div id="toolbar" class="btn-toolbar"> >- <a class="btn btn-default" id="new_sftp_server" href="/cgi-bin/koha/admin/sftp_servers.pl?op=add_form"><i class="fa fa-plus"></i> New FTP/SFTP server</a> >+ <a class="btn btn-default" id="new_sftp_server" href="/cgi-bin/koha/admin/file_transports.pl?op=add_form"><i class="fa fa-plus"></i> New file transport</a> > </div> > >- <h1>FTP/SFTP servers</h1> >+ <h1>File transports</h1> > > [% IF servers_count < 1 %] > <div class="alert alert-info" id="dno_servers_message"> > <p> >- <em>There are no FTP/SFTP servers defined.</em><br /> >- To create one, use the <strong>new FTP/SFTP server</strong> button above. >+ <em>There are no file transports defined.</em><br /> >+ To create one, use the <strong>new file transport</strong> button above. > </p> > </div> > [% ELSE %] >@@ -481,7 +481,7 @@ > "url": sftp_servers_url > }, > "language": { >- "emptyTable": "<div class=\"alert alert-info\">"+_("There are no FTP/SFTP servers defined.")+"</div>" >+ "emptyTable": "<div class=\"alert alert-info\">"+_("There are no file transports defined.")+"</div>" > }, > "columnDefs": [ { > "targets": [0,1], >@@ -617,7 +617,7 @@ > }, > { > "data": function(row, type, val, meta) { >- let result = '<a class="btn btn-default btn-xs" role="button" href="/cgi-bin/koha/admin/sftp_servers.pl?op=edit_form&sftp_server_id='+ encodeURIComponent(row.sftp_server_id) +'"><i class="fa-solid fa-pencil" aria-hidden="true"></i> '+_("Edit")+'</a>'+"\n"; >+ let result = '<a class="btn btn-default btn-xs" role="button" href="/cgi-bin/koha/admin/file_transports.pl?op=edit_form&sftp_server_id='+ encodeURIComponent(row.sftp_server_id) +'"><i class="fa-solid fa-pencil" aria-hidden="true"></i> '+_("Edit")+'</a>'+"\n"; > result += '<a class="btn btn-default btn-xs delete_server" role="button" href="#" data-bs-toggle="modal" data-bs-target="#delete_confirm_modal" data-sftp-server-id="'+ encodeURIComponent(row.sftp_server_id) +'" data-sftp-server-name="'+ encodeURIComponent(row.name.escapeHtml()) +'"><i class="fa fa-trash-can" aria-hidden="true"></i> '+_("Delete")+'</a>'; > return result; > }, >@@ -640,7 +640,7 @@ > var sftp_server_name = decodeURIComponent($(this).data('sftp-server-name')); > > $("#delete_confirm_dialog").html( >- _("You are about to delete the '%s' FTP/SFTP server.").format(sftp_server_name) >+ _("You are about to delete the '%s' file transport.").format(sftp_server_name) > ); > $("#delete_confirm_modal_button").data('sftp-server-id', sftp_server_id); > $("#delete_confirm_modal_button").data('sftp-server-name', sftp_server_name); >-- >2.51.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39190
:
178555
|
178556
|
178557
|
178558
|
178559
|
178560
|
178561
|
178562
|
178563
|
178564
|
178565
|
178566
|
178567
|
178568
|
178569
|
178570
|
178571
|
179252
|
179253
|
179254
|
179255
|
179256
|
179257
|
179258
|
179259
|
179260
|
179261
|
179262
|
179263
|
179264
|
179265
|
179266
|
179267
|
179268
|
179396
|
179397
|
179398
|
179399
|
179400
|
179401
|
179402
|
179403
|
179404
|
179405
|
179406
|
179407
|
179408
|
179409
|
179410
|
179411
|
179412
|
179413
|
179589
|
179590
|
179591
|
179592
|
179593
|
179594
|
179595
|
179596
|
179597
|
179598
|
179599
|
179600
|
179601
|
179602
|
179603
|
179604
|
179605
|
179606
|
179646
|
179647
|
179648
|
179649
|
179650
|
179651
|
179652
|
179653
|
179654
|
179655
|
179656
|
179657
|
179658
|
179659
|
179660
|
179661
|
179662
|
179663
|
179992
|
179993
|
179994
|
179995
|
179996
|
179997
|
179998
|
179999
|
180000
|
180001
|
180002
|
180003
|
180004
|
180005
|
180006
|
180010
|
180011
|
180012
|
180013
|
180014
|
180015
|
180016
|
180017
|
180018
|
180019
|
180020
|
180021
|
180022
|
180023
|
180024
|
180025
|
185014
|
185015
|
185016
|
185017
|
185018
|
185019
|
185020
|
185021
|
185022
|
185023
|
185024
|
185025
|
185026
|
185027
|
185028
|
185029
|
185972
|
185973
|
185974
|
185975
|
185976
|
185977
|
185978
|
185979
|
185980
|
185981
|
185982
|
185983
|
185984
|
185985
|
185986
|
185987
|
185988
|
185989
|
185990
|
185994
|
185995
| 185996 |
185997
|
185998