Bugzilla – Attachment 186015 Details for
Bug 40734
Libraries additional fields don't appear when creating a new library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40734: Fix creating new library with additional fields
Bug-40734-Fix-creating-new-library-with-additional.patch (text/plain), 1.80 KB, created by
David Nind
on 2025-09-01 11:54:44 UTC
(
hide
)
Description:
Bug 40734: Fix creating new library with additional fields
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-09-01 11:54:44 UTC
Size:
1.80 KB
patch
obsolete
>From 87b851ad247f0a5fea7bd94d93284024d9b8d62e Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Mon, 1 Sep 2025 10:16:45 +0000 >Subject: [PATCH] Bug 40734: Fix creating new library with additional fields > >Test plan, dont apply patch yet: >1. Go to Administration > Additional fields > Libraries (branches) > New field >2. Enter a name for the field >3. Click Save >4. Go to Administration > Libraries > New library > --> The form does not contain the additional field >5. Apply patch. Repeat. > >Signed-off-by: David Nind <david@davidnind.com> >--- > admin/branches.pl | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > >diff --git a/admin/branches.pl b/admin/branches.pl >index b6d55ea9ee..01f09839a6 100755 >--- a/admin/branches.pl >+++ b/admin/branches.pl >@@ -52,17 +52,15 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > ); > > my $library; >-if ($branchcode) { >- $library = Koha::Libraries->find($branchcode); >- my @additional_fields = Koha::AdditionalFields->search( { tablename => 'branches' } )->as_list; >- my @additional_field_values; >- @additional_field_values = $library ? $library->get_additional_field_values_for_template : (); >+$library = Koha::Libraries->find($branchcode); >+my @additional_fields = Koha::AdditionalFields->search( { tablename => 'branches' } )->as_list; >+my @additional_field_values; >+@additional_field_values = $library ? $library->get_additional_field_values_for_template : (); > >- $template->param( >- additional_fields => \@additional_fields, >- additional_field_values => @additional_field_values, >- ); >-} >+$template->param( >+ additional_fields => \@additional_fields, >+ additional_field_values => @additional_field_values, >+); > > if ( $op eq 'add_form' ) { > $template->param( >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40734
:
186013
| 186015