Bugzilla – Attachment 186065 Details for
Bug 39345
Koha must support COUNTER 5.1
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39345: (QA follow-up): Fix QA complaints
Bug-39345-QA-follow-up-Fix-QA-complaints.patch (text/plain), 2.12 KB, created by
Pedro Amorim
on 2025-09-03 09:41:46 UTC
(
hide
)
Description:
Bug 39345: (QA follow-up): Fix QA complaints
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-09-03 09:41:46 UTC
Size:
2.12 KB
patch
obsolete
>From e2040ad776557e8830a6bc6996ba3fd33e0aee50 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 21 Aug 2025 08:23:48 +0000 >Subject: [PATCH] Bug 39345: (QA follow-up): Fix QA complaints > >QA script still fails but I believe these are false positives caused by the tests files being moved > >Signed-off-by: Eric Phetteplace <phette23@gmail.com> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > Koha/ERM/EUsage/COUNTER/5_1.pm | 2 +- > t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t | 4 ++-- > t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/Koha/ERM/EUsage/COUNTER/5_1.pm b/Koha/ERM/EUsage/COUNTER/5_1.pm >index 39842d0c2e5..62e0038e124 100644 >--- a/Koha/ERM/EUsage/COUNTER/5_1.pm >+++ b/Koha/ERM/EUsage/COUNTER/5_1.pm >@@ -104,7 +104,7 @@ sub get_counter51_value { > } > } > >-=head3 _get_SUSHI_Name_Value >+=head3 get_mapped_SUSHI_values > > Given a SUSHI response, get the value for the given key in the correct format for the COUNTER report > https://counter5.cambridge.org/r51/sushi-docs/ >diff --git a/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t b/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t >index 05a603bbdf1..b7e8ccb1b01 100755 >--- a/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t >+++ b/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t >@@ -17,8 +17,8 @@ > > use Modern::Perl; > >-# use Test::NoWarnings; >-use Test::More tests => 2; >+use Test::NoWarnings; >+use Test::More tests => 3; > > use Koha::Database; > use Koha::ERM::EUsage::CounterFile; >diff --git a/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t b/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t >index da8beca5956..cdfa7d1cf57 100755 >--- a/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t >+++ b/t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t >@@ -17,8 +17,8 @@ > > use Modern::Perl; > >-# use Test::NoWarnings; >-use Test::More tests => 18; >+use Test::NoWarnings; >+use Test::More tests => 19; > > use Koha::ERM::EUsage::SushiCounter; > use Koha::Database; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39345
:
185593
|
185594
|
185595
|
185596
|
185618
|
185619
|
185620
|
185621
|
185658
|
185659
|
185660
|
185661
|
185662
|
185663
|
185664
|
185922
|
185923
|
185924
|
185925
|
185926
|
185927
|
185928
|
186016
|
186042
|
186043
|
186044
|
186060
|
186061
|
186062
|
186063
|
186064
| 186065 |
186066
|
186067
|
186068