Bugzilla – Attachment 186098 Details for
Bug 31698
Add ability to move a hold to a new bibliographic record/item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31698: (QA follow-up): Prevent display 'NaN' UI error message
Bug-31698-QA-follow-up-Prevent-display-NaN-UI-erro.patch (text/plain), 1.65 KB, created by
Pedro Amorim
on 2025-09-03 15:48:55 UTC
(
hide
)
Description:
Bug 31698: (QA follow-up): Prevent display 'NaN' UI error message
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-09-03 15:48:55 UTC
Size:
1.65 KB
patch
obsolete
>From 9c634a8fab0d4b837b3d8281fbeaa6ba9499ec27 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Wed, 3 Sep 2025 15:27:47 +0000 >Subject: [PATCH] Bug 31698: (QA follow-up): Prevent display 'NaN' UI error > message > >If the input is not a number, display an appropriate error message. >Additionally, don't make an API call unless the input is a number. > >Test by doing the following: >1) Step 19: Moving record level holds, the modal says 'Enter the biblionumber of new hold target', but if you enter 'xyz' and then search, the error shown is 'No item found with barcode: NaN'. > >This patch fixes that. > >Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 6ddee9332ee..314dfc67cd6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -986,6 +986,18 @@ $(document).ready(function () { > $("#move_hold_biblio_confirm").prop("disabled", true); > > let biblioID = parseInt($("#biblio_id").val()); >+ >+ if (Number.isNaN(biblioID)) { >+ $("#biblioResultMessage").html( >+ '<div class="alert alert-warning">' + >+ __("%s is not a valid biblionumber").format( >+ $("#biblio_id").val() >+ ) + >+ "</div>" >+ ); >+ return; >+ } >+ > let apiUrl = `/api/v1/biblios?q={"biblio_id":"${encodeURIComponent(biblioID)}"}`; > $.ajax({ > url: apiUrl, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31698
:
179226
|
179235
|
179236
|
179279
|
179287
|
179290
|
179291
|
179292
|
179295
|
179704
|
179711
|
179713
|
181222
|
181223
|
181224
|
181225
|
181226
|
181228
|
181229
|
181230
|
181231
|
181232
|
181233
|
181234
|
181929
|
181930
|
181944
|
181945
|
181946
|
181947
|
181948
|
181951
|
181952
|
181953
|
181954
|
181955
|
181956
|
181957
|
181958
|
181959
|
181960
|
181961
|
181962
|
182639
|
182640
|
182641
|
184750
|
185050
|
185064
|
185065
|
185066
|
185067
|
185068
|
185069
|
185070
|
185121
|
185379
|
185380
|
185607
|
185608
|
185609
|
185610
|
185611
|
185612
|
185613
|
185614
|
185615
|
185616
|
185753
|
185754
|
185755
|
185756
|
185757
|
185758
|
185759
|
185760
|
185761
|
185762
|
185763
|
185764
|
185765
|
185766
|
185767
|
185768
|
185769
|
185770
|
185771
|
185772
|
185773
|
185774
|
185775
|
185776
|
185834
|
186085
|
186086
|
186087
|
186088
|
186089
|
186090
|
186091
|
186092
|
186093
|
186094
|
186095
|
186096
|
186097
| 186098 |
186105
|
186115
|
186247