Bugzilla – Attachment 186115 Details for
Bug 31698
Add ability to move a hold to a new bibliographic record/item
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31698: Make strings in holds.js translatable
Bug-31698-Make-strings-in-holdsjs-translatable.patch (text/plain), 7.12 KB, created by
Pedro Amorim
on 2025-09-04 08:31:46 UTC
(
hide
)
Description:
Bug 31698: Make strings in holds.js translatable
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-09-04 08:31:46 UTC
Size:
7.12 KB
patch
obsolete
>From e68e11f8e661de2708ad62f609b6341c71c1ecb7 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 3 Sep 2025 19:19:18 +0000 >Subject: [PATCH] Bug 31698: Make strings in holds.js translatable > >Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 095b3e82477..5fae127c4c2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -976,7 +976,7 @@ $(document).ready(function () { > <strong>Biblionumber:</strong> ${item.biblio_id} <br> > <strong>Item:</strong> ${item.external_id} <br> > <input id="new_itemnumber_${item.item_id}" name="new_itemnumber" type="checkbox" value="${item.item_id}"> >- <label for="new_itemnumber_${item.item_id}">Move all selected item level holds to this item</label> >+ <label for="new_itemnumber_${item.item_id}">${__("Move all selected item level holds to this item")}</label> > <input id="new_biblionumber_${item.item_id}" name="new_biblionumber" type="hidden" value="${item.biblio_id}"> > </div> > <hr /> >@@ -985,7 +985,7 @@ $(document).ready(function () { > $("#itemResultMessage").html(resultHtml); > } else { > $("#itemResultMessage").html(` >- <div class="alert alert-warning">No item found with barcode: ${externalID}.</div> >+ <div class="alert alert-warning">${__("No item found with barcode: %s").format(externalID)}.</div> > `); > } > }, >@@ -1030,7 +1030,7 @@ $(document).ready(function () { > <div class="alert alert-success"> > <strong>Biblionumber:</strong> ${item.biblio_id} <br> > <input id="new_biblionumber_${item.biblio_id}" name="new_biblionumber" type="checkbox" value="${item.biblio_id}"> >- <label for="new_biblionumber_${item.biblio_id}">Move all selected record level holds to this record</label> >+ <label for="new_biblionumber_${item.biblio_id}">${__("Move all selected record level holds to this record")}</label> > </div> > <hr /> > `; >@@ -1038,7 +1038,7 @@ $(document).ready(function () { > $("#biblioResultMessage").html(resultHtml); > } else { > $("#biblioResultMessage").html(` >- <div class="alert alert-warning">No record found with biblionumber: ${biblioID}.</div> >+ <div class="alert alert-warning">${__("No record found with biblionumber: %s").format(externalID)}.</div> > `); > } > }, >@@ -1085,11 +1085,11 @@ $(document).ready(function () { > let found_status = $(this).data("found"); > if (item_level_hold && (!item_waiting || !item_intransit)) { > $("#move_hold_item_selection table").append( >- `<tr><td><input type="checkbox" name="move_hold_id" value="${reserve_id}" checked /></td><td>${reserve_id}</td><td>Biblionumber: <a target="_blank" href="/cgi-bin/koha/reserve/request.pl?biblionumber=${reserve_biblionumber}">${reserve_biblionumber}</a> Itemnumber: <a target="_blank" href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=${reserve_biblionumber}#item${reserve_itemnumber}">${reserve_itemnumber}</a></td><td>${error_message}</td></tr>` >+ `<tr><td><input type="checkbox" name="move_hold_id" value="${reserve_id}" checked /></td><td>${reserve_id}</td><td>${__("Biblionumber:")} <a target="_blank" href="/cgi-bin/koha/reserve/request.pl?biblionumber=${reserve_biblionumber}">${reserve_biblionumber}</a> ${__("Itemnumber:")} <a target="_blank" href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=${reserve_biblionumber}#item${reserve_itemnumber}">${reserve_itemnumber}</a></td><td>${error_message}</td></tr>` > ); > } else { > $("#move_hold_item_selection table").append( >- `<tr><td><input type="checkbox" name="move_hold_id" value="${reserve_id}" disabled /></td><td>${reserve_id}</td><td>Biblionumber: <a target="_blank" href="/cgi-bin/koha/reserve/request.pl?biblionumber=${reserve_biblionumber}">${reserve_biblionumber}</a> Itemnumber: <a target="_blank" href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=${reserve_biblionumber}#item${reserve_itemnumber}">${reserve_itemnumber}</a></td><td>${error_message}</td></tr>` >+ `<tr><td><input type="checkbox" name="move_hold_id" value="${reserve_id}" disabled /></td><td>${reserve_id}</td><td>Biblionumber: <a target="_blank" href="/cgi-bin/koha/reserve/request.pl?biblionumber=${reserve_biblionumber}">${reserve_biblionumber}</a> ${__("Itemnumber:")} <a target="_blank" href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=${reserve_biblionumber}#item${reserve_itemnumber}">${reserve_itemnumber}</a></td><td>${error_message}</td></tr>` > ); > } > }); >@@ -1119,11 +1119,11 @@ $(document).ready(function () { > let found_status = $(this).data("found"); > if (!item_level_hold && (!item_waiting || !item_intransit)) { > $("#move_hold_biblio_selection table").append( >- `<tr><td><input type="checkbox" name="move_hold_id" value="${reserve_id}" checked /><td>${reserve_id}</td><td>Biblionumber: <a target="_blank" href="/cgi-bin/koha/reserve/request.pl?biblionumber=${reserve_biblionumber}">${reserve_biblionumber}</a></td><td>${error_message}</td></tr>` >+ `<tr><td><input type="checkbox" name="move_hold_id" value="${reserve_id}" checked /><td>${reserve_id}</td><td>${__("Biblionumber:")} <a target="_blank" href="/cgi-bin/koha/reserve/request.pl?biblionumber=${reserve_biblionumber}">${reserve_biblionumber}</a></td><td>${error_message}</td></tr>` > ); > } else { > $("#move_hold_biblio_selection table").append( >- `<tr><td><input type="checkbox" name="move_hold_id" value="${reserve_id}" disabled /><td>${reserve_id}</td><td>Biblionumber: <a target="_blank" href="/cgi-bin/koha/reserve/request.pl?biblionumber=${reserve_biblionumber}">${reserve_biblionumber}</a></td><td>${error_message}</td></tr>` >+ `<tr><td><input type="checkbox" name="move_hold_id" value="${reserve_id}" disabled /><td>${reserve_id}</td><td>${__("Biblionumber:")} <a target="_blank" href="/cgi-bin/koha/reserve/request.pl?biblionumber=${reserve_biblionumber}">${reserve_biblionumber}</a></td><td>${error_message}</td></tr>` > ); > } > }); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31698
:
179226
|
179235
|
179236
|
179279
|
179287
|
179290
|
179291
|
179292
|
179295
|
179704
|
179711
|
179713
|
181222
|
181223
|
181224
|
181225
|
181226
|
181228
|
181229
|
181230
|
181231
|
181232
|
181233
|
181234
|
181929
|
181930
|
181944
|
181945
|
181946
|
181947
|
181948
|
181951
|
181952
|
181953
|
181954
|
181955
|
181956
|
181957
|
181958
|
181959
|
181960
|
181961
|
181962
|
182639
|
182640
|
182641
|
184750
|
185050
|
185064
|
185065
|
185066
|
185067
|
185068
|
185069
|
185070
|
185121
|
185379
|
185380
|
185607
|
185608
|
185609
|
185610
|
185611
|
185612
|
185613
|
185614
|
185615
|
185616
|
185753
|
185754
|
185755
|
185756
|
185757
|
185758
|
185759
|
185760
|
185761
|
185762
|
185763
|
185764
|
185765
|
185766
|
185767
|
185768
|
185769
|
185770
|
185771
|
185772
|
185773
|
185774
|
185775
|
185776
|
185834
|
186085
|
186086
|
186087
|
186088
|
186089
|
186090
|
186091
|
186092
|
186093
|
186094
|
186095
|
186096
|
186097
|
186098
|
186105
| 186115 |
186247